-
Notifications
You must be signed in to change notification settings - Fork 9
Enable promo-based Piwigo groups #824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a38adbc to
b2328c2
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #824 +/- ##
==========================================
- Coverage 85.67% 85.67% -0.01%
==========================================
Files 189 189
Lines 14572 14573 +1
==========================================
Hits 12485 12485
- Misses 2087 2088 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b2328c2 to
5e1ee57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to filter promotions being sent with the format 20xx as many users have wrongly formatted ones and each will create a useless group in piwigo
12985ec to
68e67e7
Compare
68e67e7 to
89aae40
Compare
6a76a58 to
4c90dd0
Compare
Add the promo to the "groups" claim of OIDC's "API" scope in Piwigo's auth client