fix(piefed): native android connection issues, first login infinite spinner (#2054)

Author: aeharding

package.json

@@ -96,7 +96,6 @@
     "micromark-util-combine-extensions": "^2.0.1",
     "modern-screenshot": "^4.6.4",
     "motion": "^12.18.1",
-    "openapi-fetch": "^0.14.0",
     "photoswipe": "^5.4.4",
     "react": "0.0.0-experimental-12bc60f5-20250613",
     "react-animate-height": "^3.2.3",
@@ -115,7 +114,7 @@
     "rehype-remark": "^10.0.1",
     "remark-parse": "^11.0.0",
     "remark-stringify": "^11.0.0",
-    "threadiverse": "^0.2.4",
+    "threadiverse": "^0.2.5",
     "ua-parser-js": "^2.0.3",
     "unified": "^11.0.5",
     "unist-util-visit": "^5.0.0",

pnpm-lock.yaml

@@ -18,7 +18,7 @@ import { getClient } from "#/services/client";
 import { AppDispatch, RootState } from "#/store";
 
 import { getInstanceFromHandle, instanceSelector } from "./authSelectors";
-import { receivedSite, resetSite } from "./siteSlice";
+import { getSite, resetSite } from "./siteSlice";
 
 const MULTI_ACCOUNT_STORAGE_NAME = "credentials";
 
@@ -193,14 +193,10 @@ export const register =
 
 export const addGuestInstance =
   (url: string) => async (dispatch: AppDispatch) => {
-    const client = getClient(url);
-
-    const site = await client.getSite();
-
     dispatch(resetAccountSpecificStoreData());
-    dispatch(receivedSite(site));
     dispatch(addAccount({ handle: url }));
     dispatch(updateConnectedInstance(url));
+    dispatch(getSite());
   };
 
 const addJwt =
@@ -213,9 +209,9 @@ const addJwt =
     if (!myUser) throw new Error("broke");
 
     dispatch(resetAccountSpecificStoreData());
-    dispatch(receivedSite(site));
     dispatch(addAccount({ jwt, handle: getRemoteHandle(myUser) }));
     dispatch(updateConnectedInstance(parseLemmyJWT(jwt).iss));
+    dispatch(getSite(site));
   };
 
 const resetAccountSpecificStoreData = () => (dispatch: AppDispatch) => {

src/features/auth/authSlice.ts

@@ -107,7 +107,6 @@ export const getSiteIfNeeded =
     if (getState().site.response) return;
     if (getState().site.loading) return;
 
-    dispatch(getSoftware());
     dispatch(getSite());
   };
 
@@ -133,14 +132,17 @@ export const getSoftware =
   };
 
 export const getSite =
-  () => async (dispatch: AppDispatch, getState: () => RootState) => {
+  (existingSite?: GetSiteResponse) =>
+  async (dispatch: AppDispatch, getState: () => RootState) => {
+    dispatch(getSoftware());
+
     const reqId = siteReqIdSelector(getState());
     let site;
 
     dispatch(loadingSite());
 
     try {
-      site = await clientSelector(getState()).getSite();
+      site = existingSite ?? (await clientSelector(getState()).getSite());
     } catch (error) {
       dispatch(failedSite());