Merge pull request #132 from aerele/connection-button-validation

Connection button validation

Author: Bhavan23

india_banking/hooks.py

@@ -33,6 +33,9 @@
 	"Payment Order": "india_banking.overrides.payment_order.CustomPaymentOrder",
 }
 
+override_doctype_dashboards = {
+	"Bank Account": "india_banking.india_banking.doc_events.bank_account.bank_account.get_data"
+}
 
 doc_events = {
 	"Bank": {

india_banking/india_banking/doc_events/bank_account/bank_account.py

@@ -9,6 +9,20 @@
 NAME_PATTERN = re.compile(r"^[A-Za-z0-9]+(?: [A-Za-z0-9]+)*$")
 
 
+def get_data(data=None):
+	if data is None:
+		data = {}
+
+	data.setdefault("transactions", []).append(
+		{"label": _("Connector"), "items": ["India Banking Connector"]}
+	)
+	data.setdefault("non_standard_fieldnames", {})[
+		"India Banking Connector"
+	] = "bank_account"
+
+	return data
+
+
 def validate(doc, method=None):
 	"""Validate Bank Account document before saving"""
 	strip_whitespace(doc)

india_banking/india_banking/doctype/india_banking_connector/india_banking_connector.json

@@ -16,6 +16,9 @@
   "api_key",
   "api_secret",
   "bulk_transaction",
+  "service_subscriptions_section",
+  "fetch_bank_balance",
+  "fetch_bank_statement",
   "payment_configuration_tab",
   "enqueue_large_payments_in_the_background",
   "enqueue_payments_threshold",
@@ -71,31 +74,25 @@
    "reqd": 1
   },
   {
-   "depends_on": "eval: !doc.__onload.connector_installed",
    "fieldname": "url",
    "fieldtype": "Data",
    "in_list_view": 1,
-   "label": "URL",
-   "read_only_depends_on": "!doc.__onload.connector_installed\n"
+   "label": "URL"
   },
   {
    "fieldname": "column_break_mdgf",
    "fieldtype": "Column Break"
   },
   {
-   "depends_on": "eval: !doc.__onload.connector_installed",
    "fieldname": "api_key",
    "fieldtype": "Data",
    "in_list_view": 1,
-   "label": "API Key",
-   "mandatory_depends_on": "!doc.__onload.connector_installed\n"
+   "label": "API Key"
   },
   {
-   "depends_on": "eval: !doc.__onload.connector_installed",
    "fieldname": "api_secret",
    "fieldtype": "Password",
-   "label": "API Secret",
-   "mandatory_depends_on": "!doc.__onload.connector_installed\n"
+   "label": "API Secret"
   },
   {
    "default": "0",
@@ -252,11 +249,28 @@
    "fieldtype": "Datetime",
    "label": "Last Execution",
    "read_only": 1
+  },
+  {
+   "fieldname": "service_subscriptions_section",
+   "fieldtype": "Section Break",
+   "label": "Service Subscriptions"
+  },
+  {
+   "default": "0",
+   "fieldname": "fetch_bank_balance",
+   "fieldtype": "Check",
+   "label": "Fetch Bank Balance"
+  },
+  {
+   "default": "0",
+   "fieldname": "fetch_bank_statement",
+   "fieldtype": "Check",
+   "label": "Fetch Bank Statement"
   }
  ],
  "index_web_pages_for_search": 1,
  "links": [],
- "modified": "2026-03-10 09:12:36.432674",
+ "modified": "2026-03-11 12:33:36.394960",
  "modified_by": "Administrator",
  "module": "India Banking",
  "name": "India Banking Connector",

india_banking/public/js/bank_account.js

@@ -88,8 +88,22 @@ frappe.ui.form.on("Bank Account", {
 	},
 	add_bank_custom_buttons(frm) {
 		if (!frm.doc.__islocal) {
-			frm.events.add_balance_fetch_button(frm);
-			frm.events.add_statements_fetch_button(frm);
+			let balance_service_subscribed = false;
+			frappe.db
+				.get_value("India Banking Connector", frm.doc.name, [
+					"fetch_bank_balance",
+					"fetch_bank_statement",
+				])
+				.then((r) => {
+					if (r.message) {
+						if (r.message.fetch_bank_balance) {
+							frm.events.add_balance_fetch_button(frm);
+							balance_service_subscribed = true;
+						}
+						if (r.message.fetch_bank_statement) frm.events.add_statements_fetch_button(frm);
+					}
+					if (!balance_service_subscribed) frm.set_df_property("bank_balance", "hidden", 1);
+				});
 		}
 	},
 	add_balance_fetch_button(frm) {