Don’t add spaces between marks

Author: aerni

src/Modifiers/CoreModifiers.php

@@ -283,6 +283,7 @@ public function bardText($value)
         }
 
         $text = '';
+
         while (count($value)) {
             $item = array_shift($value);
 
@@ -291,8 +292,13 @@ public function bardText($value)
             }
 
             if ($item['type'] === 'text') {
-                $text .= ' '.($item['text'] ?? '');
+                $text .= ($item['text'] ?? '');
+            }
+
+            if ($item['type'] === 'paragraph' && $text !== '') {
+                $text .= ' ';
             }
+
             array_unshift($value, ...($item['content'] ?? []));
         }
 

tests/Modifiers/BardTextTest.php

@@ -128,6 +128,34 @@ public function it_skips_nodes_with_no_type()
         $this->assertEquals($expected, $this->modify($data));
     }
 
+    #[Test]
+    public function it_preserves_text_without_adding_spaces_between_marks()
+    {
+        $data = [
+            [
+                'type' => 'paragraph',
+                'content' => [
+                    ['type' => 'text', 'text' => 'The "stat" in '],
+                    ['type' => 'text', 'marks' => [['type' => 'bold']], 'text' => 'Stat'],
+                    ['type' => 'text', 'text' => 'amic stands for "static".'],
+                ],
+            ],
+            [
+                // no type
+            ],
+            [
+                'type' => 'paragraph',
+                'content' => [
+                    ['type' => 'text', 'text' => 'Another paragraph.'],
+                ],
+            ],
+        ];
+
+        $expected = 'The "stat" in Statamic stands for "static". Another paragraph.';
+
+        $this->assertEquals($expected, $this->modify($data));
+    }
+
     public function modify($arr, ...$args)
     {
         return Modify::value($arr)->bard_text($args)->fetch();