Skip to content

Commit f3582f0

Browse files
committed
set UseBoolBin instead of casting, fix test case to default to Long
1 parent 48743f8 commit f3582f0

File tree

3 files changed

+5
-10
lines changed

3 files changed

+5
-10
lines changed

src/main/java/com/aerospike/mapper/tools/ValueType.java

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,11 +97,7 @@ public void set(final Object obj, final Object value) throws ReflectiveOperation
9797
DeferredObjectSetter objectSetter = new DeferredObjectSetter(setter, (DeferredObject) value);
9898
DeferredObjectLoader.add(objectSetter);
9999
} else {
100-
if (this.field.getType().isAssignableFrom(Boolean.class) && value instanceof Long) {
101-
this.field.set(obj, (Long) value != 0);
102-
} else {
103-
this.field.set(obj, value);
104-
}
100+
this.field.set(obj, value);
105101
}
106102
}
107103

src/main/java/com/aerospike/mapper/tools/mappers/BooleanMapper.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,21 +22,20 @@ public BooleanMapper(final ClassConfig config) {
2222

2323
@Override
2424
public Object toAerospikeFormat(Object value) {
25-
final boolean useObjectEncoding;
2625
if (ClassCache.getInstance().hasClassConfig(Boolean.class)) {
27-
useObjectEncoding = ClassCache.getInstance()
26+
UseBoolBin = ClassCache.getInstance()
2827
.getClassConfig(Boolean.class)
2928
.getBoolEncoding()
3029
.equals(Encoding.Boolean);
3130
} else {
32-
useObjectEncoding = false;
31+
UseBoolBin = false;
3332
}
3433

3534

3635
if (value == null) {
3736
return null;
3837
}
39-
if (UseBoolBin && useObjectEncoding) {
38+
if (UseBoolBin) {
4039
return value;
4140
}
4241
return ((Boolean) value) ? 1 : 0;

src/test/java/com/aerospike/mapper/DefaultFieldValuesTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ public void testBooleanValue() {
8787
UseBoolBin = true;
8888
mapper.save(obj);
8989
record = client.get(null, key);
90-
assertTrue(record.bins.get("bool2") instanceof Boolean);
90+
assertTrue(record.bins.get("bool2") instanceof Long);
9191
assertFalse(record.getBoolean("bool2"));
9292
dfc = mapper.read(DefaultFieldsClass.class, "dfc");
9393
assertFalse(dfc.bool2);

0 commit comments

Comments
 (0)