Skip to content

Commit 68a0875

Browse files
authored
Merge pull request #262 from kelostrada/bugfix/proper-errors-display
Fix changeset errors
2 parents 101c2ee + 38a89d3 commit 68a0875

File tree

3 files changed

+20
-8
lines changed

3 files changed

+20
-8
lines changed

lib/kaffy/resource_callbacks.ex

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,9 @@ defmodule Kaffy.ResourceCallbacks do
3030
{:error, :not_found} ->
3131
Kaffy.Utils.repo().insert(changeset)
3232

33+
{:error, error} ->
34+
{:error, error}
35+
3336
unexpected_error ->
3437
{:error, unexpected_error}
3538
end
@@ -62,6 +65,9 @@ defmodule Kaffy.ResourceCallbacks do
6265
{:error, :not_found} ->
6366
Kaffy.Utils.repo().update(changeset)
6467

68+
{:error, error} ->
69+
{:error, error}
70+
6571
unexpected_error ->
6672
{:error, unexpected_error}
6773
end
@@ -165,6 +171,9 @@ defmodule Kaffy.ResourceCallbacks do
165171
{:error, :not_found} ->
166172
Kaffy.Utils.repo().delete(changeset)
167173

174+
{:error, error} ->
175+
{:error, error}
176+
168177
unexpected_error ->
169178
{:error, unexpected_error}
170179
end

lib/kaffy/resource_form.ex

Lines changed: 11 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ defmodule Kaffy.ResourceForm do
130130
text_input(form, field, opts)
131131

132132
:richtext ->
133-
opts = Keyword.put(opts, :class, "kaffy-editor")
133+
opts = add_class(opts, "kaffy-editor")
134134
textarea(form, field, opts)
135135

136136
:textarea ->
@@ -146,8 +146,8 @@ defmodule Kaffy.ResourceForm do
146146
text_input(form, field, opts)
147147

148148
t when t in [:boolean, :boolean_checkbox] ->
149-
checkbox_opts = Keyword.put(opts, :class, "custom-control-input")
150-
label_opts = Keyword.put(opts, :class, "custom-control-label")
149+
checkbox_opts = add_class(opts, "custom-control-input")
150+
label_opts = add_class(opts, "custom-control-label")
151151

152152
[
153153
{:safe, ~s(<div class="custom-control custom-checkbox">)},
@@ -157,8 +157,8 @@ defmodule Kaffy.ResourceForm do
157157
]
158158

159159
:boolean_switch ->
160-
checkbox_opts = Keyword.put(opts, :class, "custom-control-input")
161-
label_opts = Keyword.put(opts, :class, "custom-control-label")
160+
checkbox_opts = add_class(opts, "custom-control-input")
161+
label_opts = add_class(opts, "custom-control-label")
162162

163163
[
164164
{:safe, ~s(<div class="custom-control custom-switch">)},
@@ -294,8 +294,8 @@ defmodule Kaffy.ResourceForm do
294294
end
295295

296296
defp flatpickr_generic(form, field, opts, placeholder, fp_class, icon \\ "📅") do
297-
opts = Keyword.put(opts, :class, "flatpickr-input")
298-
opts = Keyword.put(opts, :class, "form-control")
297+
opts = add_class(opts, "flatpickr-input")
298+
opts = add_class(opts, "form-control")
299299
opts = Keyword.put(opts, :id, "inlineFormInputGroup")
300300
opts = Keyword.put(opts, :placeholder, placeholder)
301301
opts = Keyword.put(opts, :"data-input", "")
@@ -471,4 +471,8 @@ defmodule Kaffy.ResourceForm do
471471
end
472472
end
473473
end
474+
475+
defp add_class(opts, class) do
476+
Keyword.update(opts, :class, class, &"#{&1} #{class}")
477+
end
474478
end

priv/static/assets/scss/style.css

Lines changed: 0 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)