fix select all checkbox adding empty entry in ids list, closes #129

Author: aesmail

lib/kaffy_web/controllers/resource_controller.ex

@@ -318,7 +318,6 @@ defmodule KaffyWeb.ResourceController do
         "id" => id,
         "action_key" => action_key
       }) do
-    
     my_resource = Kaffy.Utils.get_resource(conn, context, resource)
     entry = Kaffy.ResourceQuery.fetch_resource(conn, my_resource, id)
     actions = Kaffy.ResourceAdmin.resource_actions(my_resource, conn)

lib/kaffy_web/templates/layout/app.html.eex

@@ -160,9 +160,9 @@
     <script src="/kaffy/assets/js/off-canvas.js"></script>
     <script src="/kaffy/assets/js/hoverable-collapse.js"></script>
     <script src="/kaffy/assets/js/misc.js"></script>
-    <script src="/kaffy/assets/js/select-all-checkbox.js"></script>
+    <script src="/kaffy/assets/js/select-all-checkbox.js?v=20"></script>
     <script src="/kaffy/assets/js/phoenix_html.js"></script>
-    <script src="/kaffy/assets/js/dashboard.js"></script>
+    <script src="/kaffy/assets/js/dashboard.js?v=20"></script>
     <%= for js <- Kaffy.Utils.extensions(@conn).javascripts do %>
       <%= js %>
     <% end %>

priv/static/assets/js/dashboard.js

@@ -30,11 +30,11 @@ $(document).ready(function () {
     var actionForm = $(this);
     var selected = $.map($("input.kaffy-resource-checkbox:checked"), function (e) {
       return $(e).val();
-    });
+    }).filter(function (n) {
+      return n != "";
+    }).join();
 
-    $("input.kaffy-resource-checkbox:checked").each(function () {
-      $("<input />").attr("type", "hidden").attr("name", "ids").attr("value", selected.join()).appendTo(actionForm);
-    });
+    $("<input />").attr("type", "hidden").attr("name", "ids").attr("value", selected).appendTo(actionForm);
 
     return true;
   });

priv/static/assets/js/select-all-checkbox.js

@@ -29,7 +29,7 @@
     if (items.length < 1) {
       alert("no selected items!!!");
     } else {
-      var values = items.join(',');
+      var values = items.filter(function (e) { return e != ""; }).join(',');
       var html = $("<div></div>");
       html.html("selected:" + values);
       html.appendTo("body");
@@ -55,7 +55,7 @@
   function checkSelected() {
     var all = $("input.select-all")[0];
     var total = $("input.select-item").length;
-    var len = $("input.select-item:checked:checked").length;
+    var len = $("input.select-item:checked").length;
     var html = $('<span class="badge badge-secondary">' + len + " / " + total + " selected" + '</span>');
     $("#checkbox-selected-count").html(html);
     all.checked = len === total;