add serialization tests

Author: nullpilot

lib/kaffy/resource_query.ex

@@ -156,7 +156,6 @@ defmodule Kaffy.ResourceQuery do
     {query, limited_query}
   end
 
-
   defp build_list_query(_schema, [], _key_pairs) do
     {:error, "No private keys. List action not supported."}
   end

test/actions_test.exs

@@ -67,6 +67,35 @@ defmodule ActionsTest do
     end
   end
 
+  defmodule ActionsCompositeKeyAdmin do
+    @string_action "test_action"
+    @response %{product_id: 1, tag_id: 1}
+
+    def index(_), do: []
+
+    def resource_actions(_conn) do
+      %{
+        @string_action => %{
+          name: "Test Action",
+          action: fn _, _ ->
+            {:ok, @response}
+          end
+        }
+      }
+    end
+
+    def list_actions(_conn) do
+      %{
+        @string_action => %{
+          name: "Test Action",
+          action: fn _, _ ->
+            :ok
+          end
+        }
+      }
+    end
+  end
+
   defmodule FakeSchema do
     use Ecto.Schema
 
@@ -99,6 +128,12 @@ defmodule ActionsTest do
           resources: [
             test: [schema: FakeSchema, admin: ActionsMapAdmin]
           ]
+        ],
+        composite: [
+          name: "composite",
+          resources: [
+            test: [schema: KaffyTest.Schemas.Owner, admin: ActionsCompositeKeyAdmin]
+          ]
         ]
       ]
     end)
@@ -140,4 +175,32 @@ defmodule ActionsTest do
       assert %{"success" => _} = get_flash(result_conn)
     end
   end
+
+  test "single action handles composite primary keys", %{conn: conn} do
+    with_mock Kaffy.ResourceQuery, fetch_resource: fn _, _, _ -> %{product_id: 1, tag_id: 1} end do
+      result_conn =
+        ResourceController.single_action(conn, %{
+          "context" => "composite",
+          "resource" => "test",
+          "action_key" => "test_action",
+          "id" => "1:1"
+        })
+
+      assert %{"success" => _} = get_flash(result_conn)
+    end
+  end
+
+  test "list action handles composite primary keys", %{conn: conn} do
+    with_mock Kaffy.ResourceQuery, fetch_list: fn _, _ -> [%{product_id: 1, tag_id: 1}, %{product_id: 1, tag_id: 2}] end do
+      result_conn =
+        ResourceController.list_action(conn, %{
+          "context" => "composite",
+          "resource" => "test",
+          "action_key" => "test_action",
+          "id" => "1:1,1:2"
+        })
+
+      assert %{"success" => _} = get_flash(result_conn)
+    end
+  end
 end

test/kaffy_test.exs

@@ -1,7 +1,7 @@
 defmodule KaffyTest do
   use ExUnit.Case
   doctest Kaffy
-  alias KaffyTest.Schemas.{Company, Person, Pet}
+  alias KaffyTest.Schemas.{Company, Person, Pet, Owner}
   # alias KaffyTest.Admin.PersonAdmin
 
   test "greets the world" do
@@ -29,8 +29,12 @@ defmodule KaffyTest do
     end
 
     test "primary_key/1 should return a primary key" do
-      assert [:id] == ResourceSchema.primary_key(Person)
-      assert [:id] == ResourceSchema.primary_key(Pet)
+      assert [:id] == ResourceSchema.primary_keys(Person)
+      assert [:id] == ResourceSchema.primary_keys(Pet)
+    end
+
+    test "primary_key/1 should return a composite key" do
+      assert [:person_id, :pet_id] == ResourceSchema.primary_keys(Owner)
     end
 
     test "kaffy_field_name/2 should return the name of the field" do

test/resource_admin_test.exs

@@ -1,6 +1,7 @@
 defmodule Kaffy.ResourceAdminTest do
   use ExUnit.Case, async: true
   alias Kaffy.ResourceAdmin
+  alias KaffyTest.Schemas.{Owner, Pet}
 
   defmodule Cactus do
   end
@@ -15,6 +16,28 @@ defmodule Kaffy.ResourceAdminTest do
   defmodule PersonAdmin do
   end
 
+  defmodule PetAdmin do
+  end
+
+  defmodule OwnerAdmin do
+  end
+
+  defmodule OwnerETFAdmin do
+    def serialize_id(_schema, owner) do
+      {owner.person_id, owner.pet_id}
+      |> :erlang.term_to_binary()
+      |> Base.url_encode64(padding: false)
+    end
+
+    def deserialize_id(_schema, serialized_id) do
+      {person_id, pet_id} = serialized_id
+      |> Base.url_decode64!(padding: false)
+      |> :erlang.binary_to_term()
+
+      [person_id: person_id, pet_id: pet_id]
+    end
+  end
+
   defmodule Nested.Node do
   end
 
@@ -43,4 +66,32 @@ defmodule Kaffy.ResourceAdminTest do
       assert ResourceAdmin.plural_name(schema: Person, admin: PersonAdmin) == "People"
     end
   end
+
+  describe "serialize_id/2" do
+    test "serialize standard id" do
+      assert ResourceAdmin.serialize_id([schema: Pet, admin: PetAdmin], %{id: 1}) == "1"
+    end
+
+    test "serialize composite id" do
+      assert ResourceAdmin.serialize_id([schema: Owner, admin: OwnerAdmin], %{person_id: 1, pet_id: 2}) == "1:2"
+    end
+
+    test "custom serialization of composite key" do
+      assert ResourceAdmin.serialize_id([schema: Owner, admin: OwnerETFAdmin], %{person_id: 1, pet_id: 2}) == "g2gCYQFhAg"
+    end
+  end
+
+  describe "deserialize_id/2" do
+    test "deserialize standard id" do
+      assert ResourceAdmin.deserialize_id([schema: Pet, admin: PetAdmin], "1") == [id: "1"]
+    end
+
+    test "deserialize composite id" do
+      assert ResourceAdmin.deserialize_id([schema: Owner, admin: OwnerAdmin], "1:2") == [person_id: "1", pet_id: "2"]
+    end
+
+    test "custom deserialization of composite key" do
+      assert ResourceAdmin.deserialize_id([schema: Owner, admin: OwnerETFAdmin], "g2gCYQFhAg") == [person_id: "1", pet_id: "2"]
+    end
+  end
 end

test/test_helper.exs

@@ -43,3 +43,13 @@ defmodule KaffyTest.Schemas.Company do
     has_many(:people, KaffyTest.Schemas.Person)
   end
 end
+
+defmodule KaffyTest.Schemas.Owner do
+  use Ecto.Schema
+
+  @primary_key false
+  schema "owner" do
+    field :person_id, :id, primary_key: true
+    field :pet_id, :id, primary_key: true
+  end
+end