Improve unit tests

Author: afarber

openmapview/src/test/kotlin/de/afarber/openmapview/BitmapDescriptorFactoryTest.kt

@@ -18,20 +18,44 @@ import org.robolectric.RobolectricTestRunner
 @RunWith(RobolectricTestRunner::class)
 class BitmapDescriptorFactoryTest {
     @Test
-    fun testHueConstants() {
-        // Verify all HUE constants have expected values
-        assertEquals(0f, BitmapDescriptorFactory.HUE_RED, 0.001f)
-        assertEquals(30f, BitmapDescriptorFactory.HUE_ORANGE, 0.001f)
-        assertEquals(60f, BitmapDescriptorFactory.HUE_YELLOW, 0.001f)
-        assertEquals(120f, BitmapDescriptorFactory.HUE_GREEN, 0.001f)
-        assertEquals(180f, BitmapDescriptorFactory.HUE_CYAN, 0.001f)
-        assertEquals(210f, BitmapDescriptorFactory.HUE_AZURE, 0.001f)
-        assertEquals(240f, BitmapDescriptorFactory.HUE_BLUE, 0.001f)
-        assertEquals(270f, BitmapDescriptorFactory.HUE_VIOLET, 0.001f)
-        assertEquals(300f, BitmapDescriptorFactory.HUE_MAGENTA, 0.001f)
-        assertEquals(330f, BitmapDescriptorFactory.HUE_ROSE, 0.001f)
+    fun testHueConstantsAreInValidRange() {
+        val hues =
+            listOf(
+                BitmapDescriptorFactory.HUE_RED,
+                BitmapDescriptorFactory.HUE_ORANGE,
+                BitmapDescriptorFactory.HUE_YELLOW,
+                BitmapDescriptorFactory.HUE_GREEN,
+                BitmapDescriptorFactory.HUE_CYAN,
+                BitmapDescriptorFactory.HUE_AZURE,
+                BitmapDescriptorFactory.HUE_BLUE,
+                BitmapDescriptorFactory.HUE_VIOLET,
+                BitmapDescriptorFactory.HUE_MAGENTA,
+                BitmapDescriptorFactory.HUE_ROSE,
+            )
+        hues.forEach { hue ->
+            assertTrue("Hue $hue must be in 0-360 range", hue in 0f..360f)
+        }
     }
 
+    @Test
+    fun testHueConstantsAreUnique() {
+        val hues =
+            setOf(
+                BitmapDescriptorFactory.HUE_RED,
+                BitmapDescriptorFactory.HUE_ORANGE,
+                BitmapDescriptorFactory.HUE_YELLOW,
+                BitmapDescriptorFactory.HUE_GREEN,
+                BitmapDescriptorFactory.HUE_CYAN,
+                BitmapDescriptorFactory.HUE_AZURE,
+                BitmapDescriptorFactory.HUE_BLUE,
+                BitmapDescriptorFactory.HUE_VIOLET,
+                BitmapDescriptorFactory.HUE_MAGENTA,
+                BitmapDescriptorFactory.HUE_ROSE,
+            )
+        assertEquals(10, hues.size)
+    }
+
+
     @Test
     fun testDefaultMarker_Red() {
         val descriptor = BitmapDescriptorFactory.defaultMarker()

openmapview/src/test/kotlin/de/afarber/openmapview/MapTypeTest.kt

@@ -29,22 +29,44 @@ class MapTypeTest {
     }
 
     @Test
-    fun testMapTypeConstants() {
-        assertEquals(0, MapType.NONE)
-        assertEquals(1, MapType.STANDARD)
-        assertEquals(2, MapType.CYCLOSM)
-        assertEquals(3, MapType.CYCLEMAP)
-        assertEquals(4, MapType.TRANSPORT)
-        assertEquals(5, MapType.TRANSPORT_DARK)
-        assertEquals(6, MapType.TRACESTRACK_TOPO)
-        assertEquals(7, MapType.HUMANITARIAN)
-        assertEquals(8, MapType.OPNVKARTE)
-        assertEquals(9, MapType.OPENTOPOMAP)
-        assertEquals(10, MapType.CARTO_LIGHT)
-        assertEquals(11, MapType.CARTO_DARK)
-        assertEquals(12, MapType.CARTO_VOYAGER)
-        assertEquals(13, MapType.STAMEN_TONER)
-        assertEquals(14, MapType.STAMEN_WATERCOLOR)
+    fun testMapTypeConstantsAreUnique() {
+        val values =
+            setOf(
+                MapType.NONE,
+                MapType.STANDARD,
+                MapType.CYCLOSM,
+                MapType.CYCLEMAP,
+                MapType.TRANSPORT,
+                MapType.TRANSPORT_DARK,
+                MapType.TRACESTRACK_TOPO,
+                MapType.HUMANITARIAN,
+                MapType.OPNVKARTE,
+                MapType.OPENTOPOMAP,
+                MapType.CARTO_LIGHT,
+                MapType.CARTO_DARK,
+                MapType.CARTO_VOYAGER,
+                MapType.STAMEN_TONER,
+                MapType.STAMEN_WATERCOLOR,
+            )
+        assertEquals(15, values.size)
+    }
+
+
+    @Test
+    fun testAllMapTypesHaveTileSource() {
+        for (type in 0..14) {
+            val source = TileSource.fromMapType(type)
+            assertNotNull(source)
+        }
+    }
+
+    @Test
+    fun testAllMapTypesHaveDisplayName() {
+        for (type in 0..14) {
+            val name = TileSource.getMapTypeName(type)
+            assertNotNull(name)
+            assert(name != "Unknown")
+        }
     }
 
     @Test