Fix map drag detection bug (#6)

* Fix map drag detection bug

* Update the library version

Author: afarber

README.md

@@ -14,7 +14,7 @@ Add to your `build.gradle.kts`:
 
 ```kotlin
 dependencies {
-    implementation("de.afarber:openmapview:0.9.0")
+    implementation("de.afarber:openmapview:0.11.0")
 }
 ```
 

docs/PERFORMANCE.md

@@ -269,7 +269,7 @@ HttpClient(Android) {
 All requests include a user-agent header as required by OSM tile usage policy:
 
 ```kotlin
-header("User-Agent", "OpenMapView/0.1.0 (https://github.com/afarber/OpenMapView)")
+header("User-Agent", "OpenMapView/0.11.0 (https://github.com/afarber/OpenMapView)")
 ```
 
 ### Coroutine-Based Downloads

docs/REPLACING_GOOGLE_MAPS.md

@@ -107,7 +107,7 @@ dependencies {
 ```kotlin
 // Add to build.gradle.kts
 dependencies {
-    implementation("de.afarber:openmapview:0.6.0")
+    implementation("de.afarber:openmapview:0.11.0")
 }
 ```
 

openmapview/src/androidTest/kotlin/de/afarber/openmapview/TouchGestureInstrumentationTest.kt

@@ -0,0 +1,106 @@
+/*
+ * Copyright (c) 2025 Alexander Farber
+ * SPDX-License-Identifier: MIT
+ *
+ * This file is part of the OpenMapView project (https://github.com/afarber/OpenMapView)
+ */
+
+package de.afarber.openmapview
+
+import android.view.MotionEvent
+import androidx.test.ext.junit.runners.AndroidJUnit4
+import androidx.test.platform.app.InstrumentationRegistry
+import org.junit.Assert.assertFalse
+import org.junit.Assert.assertTrue
+import org.junit.Before
+import org.junit.Test
+import org.junit.runner.RunWith
+
+@RunWith(AndroidJUnit4::class)
+class TouchGestureInstrumentationTest {
+    private lateinit var openMapView: OpenMapView
+    private lateinit var controller: MapController
+
+    @Before
+    fun setUp() {
+        val context = InstrumentationRegistry.getInstrumentation().targetContext
+
+        // Create and setup view on main thread to avoid Handler creation issues
+        InstrumentationRegistry.getInstrumentation().runOnMainSync {
+            openMapView = OpenMapView(context)
+            openMapView.layout(0, 0, 1080, 1920)
+        }
+
+        controller = openMapView.getMapControllerForTesting()
+        controller.setCenter(LatLng(51.4661, 7.2491))
+        controller.setZoom(10.0f)
+    }
+
+    @Test
+    fun testLongDrag_ShouldNotRegisterAsClick() {
+        var clickReceived = false
+        openMapView.setOnMapClickListener { clickReceived = true }
+
+        val downTime = System.currentTimeMillis()
+
+        // ACTION_DOWN at (100, 100)
+        val down = MotionEvent.obtain(downTime, downTime, MotionEvent.ACTION_DOWN, 100f, 100f, 0)
+        openMapView.onTouchEvent(down)
+        down.recycle()
+
+        // Simulate multiple MOVE events (drag 200 pixels)
+        for (i in 1..10) {
+            val move =
+                MotionEvent.obtain(
+                    downTime,
+                    downTime + i * 10L,
+                    MotionEvent.ACTION_MOVE,
+                    100f + i * 20f,
+                    100f + i * 20f,
+                    0,
+                )
+            openMapView.onTouchEvent(move)
+            move.recycle()
+        }
+
+        // ACTION_UP at (300, 300) - 200 pixels away from initial position
+        val up = MotionEvent.obtain(downTime, downTime + 150, MotionEvent.ACTION_UP, 300f, 300f, 0)
+        openMapView.onTouchEvent(up)
+        up.recycle()
+
+        // Should NOT have registered as a click (distance 200px > 10px threshold)
+        assertFalse("Long drag should not register as click", clickReceived)
+    }
+
+    @Test
+    fun testSmallMovement_ShouldRegisterAsClick() {
+        var clickReceived = false
+        openMapView.setOnMapClickListener { clickReceived = true }
+
+        val downTime = System.currentTimeMillis()
+
+        // ACTION_DOWN at (100, 100)
+        val down = MotionEvent.obtain(downTime, downTime, MotionEvent.ACTION_DOWN, 100f, 100f, 0)
+        openMapView.onTouchEvent(down)
+        down.recycle()
+
+        // Small movement (3 pixels)
+        val move = MotionEvent.obtain(downTime, downTime + 50, MotionEvent.ACTION_MOVE, 103f, 103f, 0)
+        openMapView.onTouchEvent(move)
+        move.recycle()
+
+        // ACTION_UP at (103, 103) - only 3 pixels away
+        val up = MotionEvent.obtain(downTime, downTime + 100, MotionEvent.ACTION_UP, 103f, 103f, 0)
+        openMapView.onTouchEvent(up)
+        up.recycle()
+
+        // Should have registered as a click (distance 3px < 10px threshold)
+        assertTrue("Small movement should register as click", clickReceived)
+    }
+
+    private fun OpenMapView.getMapControllerForTesting(): MapController {
+        val field = OpenMapView::class.java.getDeclaredField("controller")
+        field.isAccessible = true
+        return field.get(this) as MapController
+    }
+}

openmapview/src/main/kotlin/de/afarber/openmapview/OpenMapView.kt

@@ -68,6 +68,8 @@ class OpenMapView
         private var paddingBottom = 0
         private var lastTouchX = 0f
         private var lastTouchY = 0f
+        private var initialTouchX = 0f
+        private var initialTouchY = 0f
         private var onMapClickListener: OnMapClickListener? = null
         private var onMapLongClickListener: OnMapLongClickListener? = null
         private var onMarkerDragListener: OnMarkerDragListener? = null
@@ -154,6 +156,8 @@ class OpenMapView
                     MotionEvent.ACTION_DOWN -> {
                         lastTouchX = event.x
                         lastTouchY = event.y
+                        initialTouchX = event.x
+                        initialTouchY = event.y
                         // Check if touch is on a draggable marker
                         val touchedMarker = controller.handleMarkerTouch(event.x, event.y)
                         if (touchedMarker != null && touchedMarker.draggable) {
@@ -235,8 +239,8 @@ class OpenMapView
                         isDragging = false
 
                         // Check if touch is on a marker (only if there was minimal movement)
-                        val dx = event.x - lastTouchX
-                        val dy = event.y - lastTouchY
+                        val dx = event.x - initialTouchX
+                        val dy = event.y - initialTouchY
                         val movementDistance = kotlin.math.sqrt((dx * dx + dy * dy).toDouble())
 
                         if (movementDistance < 10) {

openmapview/src/main/kotlin/de/afarber/openmapview/TileDownloader.kt

@@ -33,7 +33,7 @@ class TileDownloader {
         try {
             val response =
                 client.get(url) {
-                    header("User-Agent", "OpenMapView/0.9.0 (https://github.com/afarber/OpenMapView)")
+                    header("User-Agent", "OpenMapView/0.11.0 (https://github.com/afarber/OpenMapView)")
                 }
             val bytes = response.readRawBytes()
             // Decode with RGB_565 to reduce memory usage (2 bytes per pixel vs 4 bytes for ARGB_8888)

openmapview/src/main/kotlin/de/afarber/openmapview/UrlTileProvider.kt

@@ -62,7 +62,7 @@ abstract class UrlTileProvider(
      *
      * @return User-Agent string
      */
-    protected open fun getUserAgent(): String = "OpenMapView/0.1.0 (https://github.com/afarber/OpenMapView)"
+    protected open fun getUserAgent(): String = "OpenMapView/0.11.0 (https://github.com/afarber/OpenMapView)"
 
     /**
      * Builds the URL for the specified tile coordinates by replacing placeholders