Fixing tests.

Author: afoucret

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LogicalPlanOptimizerTests.java

@@ -9114,14 +9114,21 @@ public void testKnnWithStats() {
         );
     }
 
-    public void testKnnWithRerankAmdTopN() {
-        assertThat(typesError("""
+    public void testKnnWithRerankWithoutLimit() {
+        var query = """
             from types metadata _score
             | where knn(dense_vector, [0, 1, 2])
             | rerank "some text" on text with { "inference_id" : "reranking-inference-id" }
-            | sort _score desc
-            | limit 10
-            """), containsString("Knn function must be used with a LIMIT clause"));
+            """;
+
+        var optimized = planTypes(query);
+
+        var rerank = as(optimized, Rerank.class);
+        var limit = as(rerank.child(), Limit.class);
+        assertThat(limit.limit().fold(FoldContext.small()), equalTo(1_000));
+        var filter = as(limit.child(), Filter.class);
+        var knn = as(filter.condition(), Knn.class);
+        assertThat(knn.implicitK(), equalTo(1_000));
     }
 
     public void testKnnWithRerankAmdLimit() {

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/rules/logical/PushDownAndCombineFiltersTests.java

@@ -325,6 +325,7 @@ public void testPushDownFilterPastCompletion() {
                 EMPTY,
                 new Filter(EMPTY, relation, new And(EMPTY, conditionA, conditionB)),
                 completion.inferenceId(),
+                completion.rowLimit(),
                 completion.prompt(),
                 completion.targetField()
             ),
@@ -357,6 +358,7 @@ public void testPushDownFilterPastRerank() {
                 EMPTY,
                 new Filter(EMPTY, relation, new And(EMPTY, conditionA, conditionB)),
                 rerank.inferenceId(),
+                rerank.rowLimit(),
                 rerank.queryText(),
                 rerank.rerankFields(),
                 rerank.scoreAttribute()
@@ -372,6 +374,7 @@ private static Completion completion(LogicalPlan child) {
             EMPTY,
             child,
             randomLiteral(DataType.KEYWORD),
+            randomLiteral(DataType.INTEGER),
             randomLiteral(randomBoolean() ? DataType.TEXT : DataType.KEYWORD),
             referenceAttribute(randomIdentifier(), DataType.KEYWORD)
         );
@@ -382,6 +385,7 @@ private static Rerank rerank(LogicalPlan child) {
             EMPTY,
             child,
             randomLiteral(DataType.KEYWORD),
+            randomLiteral(DataType.INTEGER),
             randomLiteral(randomBoolean() ? DataType.TEXT : DataType.KEYWORD),
             randomList(1, 10, () -> new Alias(EMPTY, randomIdentifier(), randomLiteral(DataType.KEYWORD))),
             referenceAttribute(randomBoolean() ? MetadataAttribute.SCORE : randomIdentifier(), DataType.DOUBLE)