Skip to content

Commit d773bcb

Browse files
authored
ES|QL: rm duplicate hashCode and equals (elastic#141102)
1 parent bef315d commit d773bcb

File tree

5 files changed

+0
-69
lines changed

5 files changed

+0
-69
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/inference/CompletionFunction.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717

1818
import java.io.IOException;
1919
import java.util.List;
20-
import java.util.Objects;
2120

2221
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.FIRST;
2322
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.SECOND;
@@ -135,17 +134,4 @@ protected NodeInfo<? extends Expression> info() {
135134
public String toString() {
136135
return "COMPLETION(" + prompt + ", " + inferenceId + ")";
137136
}
138-
139-
@Override
140-
public boolean equals(Object o) {
141-
if (o == null || getClass() != o.getClass()) return false;
142-
if (super.equals(o) == false) return false;
143-
CompletionFunction completionFunction = (CompletionFunction) o;
144-
return Objects.equals(inferenceId, completionFunction.inferenceId) && Objects.equals(prompt, completionFunction.prompt);
145-
}
146-
147-
@Override
148-
public int hashCode() {
149-
return Objects.hash(super.hashCode(), inferenceId, prompt);
150-
}
151137
}

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/inference/TextEmbedding.java

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@
2222

2323
import java.io.IOException;
2424
import java.util.List;
25-
import java.util.Objects;
2625

2726
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.FIRST;
2827
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.SECOND;
@@ -155,17 +154,4 @@ protected NodeInfo<? extends Expression> info() {
155154
public String toString() {
156155
return "TEXT_EMBEDDING(" + inputText + ", " + inferenceId + ")";
157156
}
158-
159-
@Override
160-
public boolean equals(Object o) {
161-
if (o == null || getClass() != o.getClass()) return false;
162-
if (super.equals(o) == false) return false;
163-
TextEmbedding textEmbedding = (TextEmbedding) o;
164-
return Objects.equals(inferenceId, textEmbedding.inferenceId) && Objects.equals(inputText, textEmbedding.inputText);
165-
}
166-
167-
@Override
168-
public int hashCode() {
169-
return Objects.hash(super.hashCode(), inferenceId, inputText);
170-
}
171157
}

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/multivalue/MvAppend.java

Lines changed: 0 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@
3636
import java.io.IOException;
3737
import java.util.Arrays;
3838
import java.util.List;
39-
import java.util.Objects;
4039

4140
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.FIRST;
4241
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.SECOND;
@@ -196,20 +195,6 @@ public DataType dataType() {
196195
return dataType;
197196
}
198197

199-
@Override
200-
public int hashCode() {
201-
return Objects.hash(field1, field2);
202-
}
203-
204-
@Override
205-
public boolean equals(Object obj) {
206-
if (obj == null || obj.getClass() != getClass()) {
207-
return false;
208-
}
209-
MvAppend other = (MvAppend) obj;
210-
return Objects.equals(other.field1, field1) && Objects.equals(other.field2, field2);
211-
}
212-
213198
@Evaluator(extraName = "Int")
214199
static void process(IntBlock.Builder builder, @Position int position, IntBlock field1, IntBlock field2) {
215200
int count1 = field1.getValueCount(position);

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/Chunk.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@
3939
import java.io.IOException;
4040
import java.util.List;
4141
import java.util.Map;
42-
import java.util.Objects;
4342
import java.util.stream.Collectors;
4443

4544
import static java.util.Map.entry;
@@ -225,18 +224,6 @@ static void process(BytesRefBlock.Builder builder, BytesRef str, @Fixed Chunking
225224
emitChunks(builder, chunks);
226225
}
227226

228-
@Override
229-
public boolean equals(Object o) {
230-
if (o == null || getClass() != o.getClass()) return false;
231-
Chunk chunk = (Chunk) o;
232-
return Objects.equals(field(), chunk.field()) && Objects.equals(chunkingSettings(), chunk.chunkingSettings());
233-
}
234-
235-
@Override
236-
public int hashCode() {
237-
return Objects.hash(field(), chunkingSettings());
238-
}
239-
240227
@Override
241228
public EvalOperator.ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
242229
ChunkingSettings chunkingSettings = DEFAULT_CHUNKING_SETTINGS;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/string/TopSnippets.java

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,6 @@
4040
import java.util.HashMap;
4141
import java.util.List;
4242
import java.util.Map;
43-
import java.util.Objects;
4443

4544
import static java.util.Map.entry;
4645
import static org.elasticsearch.xpack.esql.core.expression.TypeResolutions.ParamOrdinal.FIRST;
@@ -228,18 +227,6 @@ static void process(
228227
emitChunks(builder, snippets);
229228
}
230229

231-
@Override
232-
public boolean equals(Object o) {
233-
if (o == null || getClass() != o.getClass()) return false;
234-
TopSnippets chunk = (TopSnippets) o;
235-
return Objects.equals(field, chunk.field) && Objects.equals(query, chunk.query) && Objects.equals(options, chunk.options);
236-
}
237-
238-
@Override
239-
public int hashCode() {
240-
return Objects.hash(field, query, options);
241-
}
242-
243230
@Override
244231
public EvalOperator.ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
245232
int numSnippets;

0 commit comments

Comments
 (0)