Skip to content

Commit 6f4f984

Browse files
authored
Merge pull request #32 from afresh-technologies/update-fork
Update fork
2 parents 3a0d33b + c1e5732 commit 6f4f984

File tree

3 files changed

+27
-8
lines changed

3 files changed

+27
-8
lines changed

.scripts/package.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,8 @@ rename_frameworks () {
6565
zip_frameworks () {
6666
for i in */*.xcframework; do (
6767
local name=$(xcframework_name $i)
68-
cd "$i/../"; zip -rqo "$name.xcframework.zip" "$name.xcframework"
68+
# Preserve symlinks using the -y option
69+
cd "$i/../"; zip -ryqo "$name.xcframework.zip" "$name.xcframework"
6970
) & done;
7071
wait
7172
}

CONTRIBUTING.md

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,26 @@
1+
# How the Package is generated
2+
3+
The `Package.swift` and `Sources` files are automatically generated via a [script](https://github.com/akaffenberger/firebase-ios-sdk-xcframeworks/blob/master/.scripts/package.sh), which is set to run in a scheduled cron job via Github Actions.
4+
5+
The script performs the following actions:
6+
- Downloads the latest release from https://github.com/firebase/firebase-ios-sdk
7+
- Parses the Firebase.zip to generate Package.swift and Sources/
8+
- Commits changes on a new branch and creates a PR
9+
- Creates a draft release, with a tag that mirrors the Firebase release. The draft release includes the assets needed for the swift package
10+
11+
## Running the script locally
12+
- Install github cli: `$ brew install gh`
13+
- Generate the swift package: `$ cd .scripts && sh package.sh debug skip-release`
14+
15+
## Testing locally
16+
There is an iOS Example project that can be used to test that the Package is working as expected.
17+
- Open the `iOS Example.xcworkspace`
18+
- Build and run in XCode
19+
- Examples currently available for testing:
20+
- Firestore
21+
- In App Messaging
22+
- Google Sign In
23+
124
# Contribution Guidelines
225
Any and all input is welcome, including:
326

README.md

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -42,13 +42,8 @@ Firebase currently supports SPM integration, see the [official SDK integration i
4242
```
4343
4444
- Add `-ObjC` to Build Settings -> Other Linker Flags
45-
- Some Firebase frameworks require resource bundles. To include those, there are two options:
46-
47-
Use the provided script to automatically include all Firebase resources. Copy the following into a Run Script Phase:
48-
```
49-
sh "${BUILD_DIR%Build/*}SourcePackages/checkouts/firebase-ios-sdk-xcframeworks/.scripts/resources.sh"
50-
```
51-
Or, manually drag and drop specific resource bundles into your target's Copy Bundle Resources Phase:
45+
- Some Firebase frameworks require resource bundles. Drag and drop the ones you need into your target's Copy Bundle Resources Phase:
46+
5247
![](./assets/draganddrop.gif)
5348
5449
# How it works

0 commit comments

Comments
 (0)