PR feedback

Author: vgreb

compose.yml

@@ -56,6 +56,8 @@ services:
       APP_ENV: "test"
       HOST_PWD: ${PWD}
       SYMFONY_IDE: "%env(IDE_USED)%://open?url=file://%%f&line=%%l&/var/www/html/>%env(HOST_PWD)%/"
+      PANTHER_NO_SANDBOX: 1
+      PANTHER_CHROME_ARGUMENTS: '--disable-dev-shm-usage --disable-features=IsolateOrigins,site-per-process,TrackingProtection3pcd'
     env_file:
       .env
     volumes:

sources/AppBundle/Controller/Admin/Accounting/Quotation/EditQuotationAction.php

@@ -42,8 +42,8 @@ public function __invoke(Request $request): Response
                         $existingIds[] = $detail->getId();
                     }
                     $detail->setInvoicingId($quotation->getId());
-                    $this->unitOfWork->pushSave($detail);
-//                    $this->invoicingDetailRepository->save($detail);
+//                    $this->unitOfWork->pushSave($detail);
+                    $this->invoicingDetailRepository->save($detail);
                 }
 
                 $idsToRemove = array_diff($idsToRemove, $existingIds);

tests/behat/bootstrap/FeatureContext.php

@@ -11,6 +11,7 @@
 use Behat\Hook\BeforeScenario;
 use Behat\Mink\Driver\PantherDriver;
 use Behat\Mink\Exception\ExpectationException;
+use Behat\Mink\Exception\UnsupportedDriverActionException;
 use Behat\MinkExtension\Context\MinkContext;
 use Behat\Step\Then;
 use Behat\Step\When;
@@ -219,6 +220,9 @@ public function theCurrentDateIs(string $date): void
     #[Then('/^(?:|I )click on link with (class|id) "(?P<text>(?:[^"]|\\")*)"$/')]
     public function clickOnLink(string $type, string $text): void
     {
+        if (!$this->minkContext->getSession()->getDriver() instanceof PantherDriver) {
+            throw new UnsupportedDriverActionException('javascript is not supported by driver %s', $this->minkContext->getSession()->getDriver());
+        }
         $selector = match ($type) {
             'class' => 'a.' . $text,
             'id' => 'a#' . $text,
@@ -244,7 +248,10 @@ public function openMenu(string $text): void
     #[Then('/^wait (?P<value>(?:[0-9])*)(ms|s)$/')]
     public function wait(string $text, string $unit): void
     {
+        echo time();
         $value = intval($text) * (strtolower($unit) === 'ms' ? 1 : 1000);
+        dump($value);
         \usleep($value);
+        echo time();
     }
 }

tests/behat/features/Admin/Tresorerie/DevisFactures.feature

@@ -17,7 +17,7 @@ Feature: Administration - Trésorerie - Devis/Facture
     And I fill in "quotation[zipcode]" with "21000"
     And I fill in "quotation[email]" with "martine@ens-corp.biz"
     When I press "Ajouter"
-    And wait 2s
+#    And wait 2s
     Then I should see "L'écriture a été ajoutée"
     And I should see "ESN Corp"
     And I should see "0,00"
@@ -52,7 +52,7 @@ Feature: Administration - Trésorerie - Devis/Facture
     And I fill in "quotation[details][1][quantity]" with "1"
     And I fill in "quotation[details][1][unitPrice]" with "12000"
     When I press "Ajouter"
-    And wait 2s
+#    And wait 2s
     Then I should see "L'écriture a été ajoutée"
     And I should see "ESN dev en folie"
     And I should see "Paris"
@@ -66,7 +66,7 @@ Feature: Administration - Trésorerie - Devis/Facture
     When I follow the button of tooltip "Modifier le devis ESN dev en folie"
     And I fill in "quotation[city]" with "Paris Cedex 1"
     When I press "Modifier"
-    And wait 3s
+#    And wait 3s
     Then I should see "L'écriture a été modifiée"
     And I should see "ESN dev en folie"
     And I should see "Paris Cedex 1"