allow user to control ADC chopping

Author: markzakharyan

m4/.gitignore

@@ -3,3 +3,4 @@
 .vscode/c_cpp_properties.json
 .vscode/launch.json
 .vscode/ipch
+*.code-workspace

m4/src/Peripherals/ADC/ADCBoard.h

@@ -69,6 +69,8 @@
 #define ADC2DOUBLE(vin) ADC2DOUBLE24(vin)
 
 class ADCBoard {
+ public:
+  bool chopEnabled = true;
  private:
   int cs_pin;
   int data_ready_pin;
@@ -409,17 +411,15 @@ class ADCBoard {
     return comm;
   }
 
-  // chop = true
   float setConversionTime(int channel, float time_us) {
     return setConversionTimeFloat(channel, time_us,
                                   isMoreThanOneChannelActive());
   }
 
-  // chop = true
   float setConversionTimeFloat(int channel, float time_us,
                                bool moreThanOneChannelActive) {
     return setConversionTime(
-        channel, true,
+        channel, chopEnabled,
         calculateFilterWord(time_us, true, moreThanOneChannelActive),
         moreThanOneChannelActive);
   }

m4/src/Peripherals/ADC/ADCController.h

@@ -72,6 +72,8 @@ class ADCController {
     registerMemberFunction(setChFullScaleCalibration, "SET_FULL_SCALE_CAL");
     registerMemberFunction(resetToPreviousConversionTimesSerial,"RESET_MAINTAIN");
     registerMemberFunction(hardResetAllADCBoards, "HARD_RESET");
+    registerMemberFunction(setChopping, "SET_CHOP");
+    registerMemberFunction(getChopping, "GET_CHOP");
   }
 
   inline static void addBoard(int cs_pin, int data_ready,
@@ -112,6 +114,17 @@ class ADCController {
         getChannelIndexFromGlobalIndex(channel_index));
   }
 
+  inline static OperationResult setChopping(bool chop) {
+    for (auto& board : adc_boards) {
+      board.chopEnabled = chop;
+    }
+    return OperationResult::Success();
+  }
+
+  inline static OperationResult getChopping() {
+    return adc_boards[0].chopEnabled ? OperationResult::Success("true") : OperationResult::Success("false");
+  }
+
   inline static OperationResult getRevisionRegister(int board_index) {
     if (board_index < 0 || board_index >= adc_boards.size()) {
       return OperationResult::Failure("Invalid board index");

m4/src/Peripherals/God.h

@@ -384,13 +384,9 @@ class God {
       DACController::setVoltageNoTransactionNoLdac(dacChannels[i], dacV0s[i]);
       nextVoltageSet[i] += voltageStepSize[i];
     }
-    DACController::toggleLdac();
+
     steps++;
 
-    for (int i = 0; i < numDacChannels; i++) {
-      DACController::setVoltageNoTransactionNoLdac(dacChannels[i], nextVoltageSet[i]);
-      nextVoltageSet[i] += voltageStepSize[i];
-    }
 
     for (int i = 0; i < numAdcChannels; i++) {
       ADCController::startContinuousConversion(adcChannels[i]);