Skip to content

Commit 66121ea

Browse files
authored
Remove unneeded .fixme and fix more tests (#325)
* Chore: remove e2e2 package * add report command * re-enable all tests * Fix bug with haiku render order in tool based gen ui * fix checkpointer missing in fastapi langgraph toolbasedgenui * rename misspelled files * Make menu bar sorted for easier viewability * omit mastra tool based gen * more fixme * fix some strict mode errors * Last remaining fixme * mark 2 more flaky tests * Add comments on fixmes
1 parent e2036fa commit 66121ea

39 files changed

+105
-446
lines changed

typescript-sdk/apps/dojo/e2e/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,8 @@
66
"scripts": {
77
"postinstall": "playwright install --with-deps",
88
"test": "playwright test",
9-
"test:ui": "playwright test --ui"
9+
"test:ui": "playwright test --ui",
10+
"report": "playwright show-report"
1011
},
1112
"devDependencies": {
1213
"@playwright/test": "^1.43.1",

typescript-sdk/apps/dojo/e2e/pages/crewAIPages/PredictiveStateUpdatesPage.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export class PredictiveStateUpdatesPage {
3030
this.userMessage = page.locator('.copilotKitUserMessage');
3131
}
3232

33-
async openChat() {
33+
async openChat() {
3434
await this.agentGreeting.isVisible();
3535
}
3636

@@ -54,13 +54,13 @@ export class PredictiveStateUpdatesPage {
5454
}
5555

5656
async getUserApproval() {
57-
await this.userApprovalModal.isVisible();
57+
await this.userApprovalModal.last().isVisible();
5858
await this.getButton(this.page, "Confirm");
59-
const acceptedLabel = this.userApprovalModal.locator('text=✓ Accepted');
59+
const acceptedLabel = this.userApprovalModal.last().locator('text=✓ Accepted');
6060
}
6161

6262
async getUserRejection() {
63-
await this.userApprovalModal.isVisible();
63+
await this.userApprovalModal.last().isVisible();
6464
await this.getButton(this.page, "Reject");
6565
const rejectedLabel = await this.getStatusLabelOfButton(this.page, "✕ Rejected");
6666
await rejectedLabel.isVisible();
@@ -85,15 +85,15 @@ export class PredictiveStateUpdatesPage {
8585
'div.tiptap em',
8686
'div.tiptap s'
8787
];
88-
88+
8989
let count = 0;
9090
for (const selector of highlightSelectors) {
9191
count = await this.page.locator(selector).count();
9292
if (count > 0) {
9393
break;
9494
}
9595
}
96-
96+
9797
if (count > 0) {
9898
expect(count).toBeGreaterThan(0);
9999
} else {

typescript-sdk/apps/dojo/e2e/pages/pydanticAIPages/PredictiveStateUpdatesPage.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ export class PredictiveStateUpdatesPage {
3030
this.userMessage = page.locator('.copilotKitUserMessage');
3131
}
3232

33-
async openChat() {
33+
async openChat() {
3434
await this.agentGreeting.isVisible();
3535
}
3636

@@ -54,13 +54,13 @@ export class PredictiveStateUpdatesPage {
5454
}
5555

5656
async getUserApproval() {
57-
await this.userApprovalModal.isVisible();
57+
await this.userApprovalModal.last().isVisible();
5858
await this.getButton(this.page, "Confirm");
59-
const acceptedLabel = this.userApprovalModal.locator('text=✓ Accepted');
59+
const acceptedLabel = this.userApprovalModal.last().locator('text=✓ Accepted');
6060
}
6161

6262
async getUserRejection() {
63-
await this.userApprovalModal.isVisible();
63+
await this.userApprovalModal.last().isVisible();
6464
await this.getButton(this.page, "Reject");
6565
const rejectedLabel = await this.getStatusLabelOfButton(this.page, "✕ Rejected");
6666
await rejectedLabel.isVisible();
@@ -85,15 +85,15 @@ export class PredictiveStateUpdatesPage {
8585
'div.tiptap em',
8686
'div.tiptap s'
8787
];
88-
88+
8989
let count = 0;
9090
for (const selector of highlightSelectors) {
9191
count = await this.page.locator(selector).count();
9292
if (count > 0) {
9393
break;
9494
}
9595
}
96-
96+
9797
if (count > 0) {
9898
expect(count).toBeGreaterThan(0);
9999
} else {

typescript-sdk/apps/dojo/e2e/tests/agnoTests/toolBasedGenUIPage.spec.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import { ToolBaseGenUIPage } from "../../pages/agnoPages/ToolBaseGenUIPage";
44
const pageURL =
55
"/agno/feature/tool_based_generative_ui";
66

7-
test.fixme('[Agno] Haiku generation and display verification', async ({
7+
test('[Agno] Haiku generation and display verification', async ({
88
page,
99
}) => {
1010
await page.goto(pageURL);
@@ -17,7 +17,7 @@ test.fixme('[Agno] Haiku generation and display verification', async ({
1717
await genAIAgent.checkHaikuDisplay(page);
1818
});
1919

20-
test.fixme('[Agno] Haiku generation and UI consistency for two different prompts', async ({
20+
test('[Agno] Haiku generation and UI consistency for two different prompts', async ({
2121
page,
2222
}) => {
2323
await page.goto(pageURL);

typescript-sdk/apps/dojo/e2e/tests/crewAITests/agenticChatPage.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ test("[CrewAI] Agentic Chat sends and receives a message", async ({
2626
});
2727
});
2828

29-
test.fixme("[CrewAI] Agentic Chat changes background on message and reset", async ({
29+
test("[CrewAI] Agentic Chat changes background on message and reset", async ({
3030
page,
3131
}) => {
3232
await retryOnAIFailure(async () => {

typescript-sdk/apps/dojo/e2e/tests/crewAITests/agenticGenUI.spec.ts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { test, expect } from "@playwright/test";
22
import { AgenticGenUIPage } from "../../pages/crewAIPages/AgenticUIGenPage";
33

44
test.describe("Agent Generative UI Feature", () => {
5+
// Flaky
56
test.fixme("[CrewAI] should interact with the chat to get a planner on prompt", async ({
67
page,
78
}) => {
@@ -33,6 +34,7 @@ test.describe("Agent Generative UI Feature", () => {
3334
);
3435
});
3536

37+
// Flaky
3638
test.fixme("[CrewAI] should interact with the chat using predefined prompts and perform steps", async ({
3739
page,
3840
}) => {
File renamed without changes.

typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/agenticGenUI.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ test.describe("Agent Generative UI Feature", () => {
3535
);
3636
});
3737

38-
test.fixme("[LangGraph FastAPI] should interact with the chat using predefined prompts and perform steps", async ({
38+
test("[LangGraph FastAPI] should interact with the chat using predefined prompts and perform steps", async ({
3939
page,
4040
}) => {
4141
const genUIAgent = new AgenticGenUIPage(page);
File renamed without changes.

typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/sharedStatePage.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ test.describe("Shared State Feature", () => {
2121
);
2222
});
2323

24-
test.fixme("[LangGraph FastAPI] should share state between UI and chat", async ({
24+
test("[LangGraph FastAPI] should share state between UI and chat", async ({
2525
page,
2626
}) => {
2727
const sharedStateAgent = new SharedStatePage(page);

0 commit comments

Comments
 (0)