Skip to content

Commit 7abe5b9

Browse files
Merge pull request #52 from Contextable/general-cleanup
General cleanup
2 parents b7aca0f + 4ce24b9 commit 7abe5b9

File tree

3 files changed

+9
-17
lines changed

3 files changed

+9
-17
lines changed

typescript-sdk/integrations/adk-middleware/src/adk_middleware/adk_agent.py

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,7 @@
1111
from ag_ui.core import (
1212
RunAgentInput, BaseEvent, EventType,
1313
RunStartedEvent, RunFinishedEvent, RunErrorEvent,
14-
TextMessageStartEvent, TextMessageContentEvent, TextMessageEndEvent,
15-
StateSnapshotEvent, StateDeltaEvent,
16-
Context, ToolMessage, ToolCallEndEvent, SystemMessage,ToolCallResultEvent
14+
ToolCallEndEvent, SystemMessage,ToolCallResultEvent
1715
)
1816

1917
from google.adk import Runner
@@ -406,7 +404,7 @@ async def _handle_tool_result_submission(
406404
# Extract tool results that is send by the frontend
407405
tool_results = await self._extract_tool_results(input)
408406

409-
# if the tool results are not send by the fronted then call the tool function
407+
# if the tool results are not sent by the fronted then call the tool function
410408
if not tool_results:
411409
logger.error(f"Tool result submission without tool results for thread {thread_id}")
412410
yield RunErrorEvent(
@@ -476,7 +474,7 @@ async def _extract_tool_results(self, input: RunAgentInput) -> List[Dict]:
476474
tool_name = tool_call_map.get(most_recent_tool_message.tool_call_id, "unknown")
477475

478476
# Debug: Log the extracted tool message
479-
logger.info(f"Extracted most recent ToolMessage: role={most_recent_tool_message.role}, tool_call_id={most_recent_tool_message.tool_call_id}, content='{most_recent_tool_message.content}'")
477+
logger.debug(f"Extracted most recent ToolMessage: role={most_recent_tool_message.role}, tool_call_id={most_recent_tool_message.tool_call_id}, content='{most_recent_tool_message.content}'")
480478

481479
return [{
482480
'tool_name': tool_name,
@@ -819,7 +817,7 @@ async def _run_adk_in_background(
819817
content = tool_msg['message'].content
820818

821819
# Debug: Log the actual tool message content we received
822-
logger.info(f"Received tool result for call {tool_call_id}: content='{content}', type={type(content)}")
820+
logger.debug(f"Received tool result for call {tool_call_id}: content='{content}', type={type(content)}")
823821

824822
# Parse JSON content, handling empty or invalid JSON gracefully
825823
try:

typescript-sdk/integrations/adk-middleware/src/adk_middleware/event_translator.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -11,11 +11,8 @@
1111
BaseEvent, EventType,
1212
TextMessageStartEvent, TextMessageContentEvent, TextMessageEndEvent,
1313
ToolCallStartEvent, ToolCallArgsEvent, ToolCallEndEvent,
14-
ToolCallChunkEvent,ToolCallResultEvent,
15-
StateSnapshotEvent, StateDeltaEvent,
16-
MessagesSnapshotEvent,
17-
CustomEvent,
18-
Message, AssistantMessage, UserMessage, ToolMessage
14+
ToolCallResultEvent, StateSnapshotEvent, StateDeltaEvent,
15+
CustomEvent
1916
)
2017
import json
2118
from google.adk.events import Event as ADKEvent
@@ -71,7 +68,7 @@ async def translate(
7168
# Determine action based on ADK streaming pattern
7269
should_send_end = turn_complete and not is_partial
7370

74-
logger.info(f"📥 ADK Event: partial={is_partial}, turn_complete={turn_complete}, "
71+
logger.debug(f"📥 ADK Event: partial={is_partial}, turn_complete={turn_complete}, "
7572
f"is_final_response={is_final_response}, should_send_end={should_send_end}")
7673

7774
# Skip user events (already in the conversation)
@@ -86,9 +83,6 @@ async def translate(
8683
):
8784
yield event
8885

89-
90-
91-
9286
# call _translate_function_calls function to yield Tool Events
9387
if hasattr(adk_event, 'get_function_calls'):
9488
function_calls = adk_event.get_function_calls()

typescript-sdk/integrations/adk-middleware/src/adk_middleware/utils/converters.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ def convert_ag_ui_messages_to_adk(messages: List[Message]) -> List[ADKEvent]:
7474
role="function",
7575
parts=[types.Part(
7676
function_response=types.FunctionResponse(
77-
name=message.tool_call_id, # This might need adjustment
77+
name=message.tool_call_id,
7878
response={"result": message.content} if isinstance(message.content, str) else message.content,
7979
id=message.tool_call_id
8080
)
@@ -115,7 +115,7 @@ def convert_adk_event_to_ag_ui_message(event: ADKEvent) -> Optional[Message]:
115115
content="\n".join(text_parts)
116116
)
117117

118-
elif event.author != "user": # Assistant/model response
118+
else: # Assistant/model response
119119
# Extract text and tool calls
120120
text_parts = []
121121
tool_calls = []

0 commit comments

Comments
 (0)