Skip to content

Commit a259d47

Browse files
committed
chore: refrain from attempting to open an always open chat
1 parent b14e0d1 commit a259d47

File tree

13 files changed

+1
-44
lines changed

13 files changed

+1
-44
lines changed

typescript-sdk/apps/dojo/e2e/pages/langGraphFastAPIPages/AgenticChatPage.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import { Page, Locator, expect } from "@playwright/test";
22

33
export class AgenticChatPage {
44
readonly page: Page;
5-
readonly openChatButton: Locator;
65
readonly agentGreeting: Locator;
76
readonly chatInput: Locator;
87
readonly sendButton: Locator;
@@ -12,9 +11,6 @@ export class AgenticChatPage {
1211

1312
constructor(page: Page) {
1413
this.page = page;
15-
this.openChatButton = page.getByRole("button", {
16-
name: /chat/i,
17-
});
1814
this.agentGreeting = page
1915
.getByText("Hi, I'm an agent. Want to chat?");
2016
this.chatInput = page
@@ -36,14 +32,6 @@ export class AgenticChatPage {
3632
.locator(".copilotKitUserMessage");
3733
}
3834

39-
async openChat() {
40-
try {
41-
await this.openChatButton.click({ timeout: 3000 });
42-
} catch (error) {
43-
// Chat might already be open
44-
}
45-
}
46-
4735
async sendMessage(message: string) {
4836
await this.chatInput.click();
4937
await this.chatInput.fill(message);

typescript-sdk/apps/dojo/e2e/tests/agnoTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[Agno] Agentic Chat sends and receives a greeting message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi");
2221

@@ -36,7 +35,6 @@ test("[Agno] Agentic Chat provides stock price information", async ({
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Ask for AAPL stock price
@@ -58,7 +56,6 @@ test("[Agno] Agentic Chat retains memory of previous questions", async ({
5856
);
5957

6058
const chat = new AgenticChatPage(page);
61-
await chat.openChat();
6259
await chat.agentGreeting.waitFor({ state: "visible" });
6360

6461
// First question
@@ -87,7 +84,6 @@ test("[Agno] Agentic Chat retains memory of user messages during a conversation"
8784
);
8885

8986
const chat = new AgenticChatPage(page);
90-
await chat.openChat();
9187
await chat.agentGreeting.click();
9288

9389
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/crewAITests/agenticChatPage.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[CrewAI] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test.fixme("[CrewAI] Agentic Chat changes background on message and reset", asyn
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -83,7 +81,6 @@ test("[CrewAI] Agentic Chat retains memory of user messages during a conversatio
8381
);
8482

8583
const chat = new AgenticChatPage(page);
86-
await chat.openChat();
8784
await chat.agentGreeting.click();
8885

8986
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/langgraphFastAPITests/agenticChatPage.spec.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[LangGraph FastAPI] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test("[LangGraph FastAPI] Agentic Chat changes background on message and reset",
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -48,6 +46,7 @@ test("[LangGraph FastAPI] Agentic Chat changes background on message and reset",
4846
await chat.assertUserMessageVisible(
4947
"Hi change the background color to blue"
5048
);
49+
5150
await waitForAIResponse(page);
5251

5352
const backgroundBlue = await chat.getBackground();
@@ -83,7 +82,6 @@ test("[LangGraph FastAPI] Agentic Chat retains memory of user messages during a
8382
);
8483

8584
const chat = new AgenticChatPage(page);
86-
await chat.openChat();
8785
await chat.agentGreeting.click();
8886

8987
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/langgraphTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[LangGraph] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test("[LangGraph] Agentic Chat changes background on message and reset", async (
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -78,7 +76,6 @@ test("[LangGraph] Agentic Chat retains memory of user messages during a conversa
7876
);
7977

8078
const chat = new AgenticChatPage(page);
81-
await chat.openChat();
8279
await chat.agentGreeting.click();
8380

8481
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/llamaIndexTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[LlamaIndex] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test("[LlamaIndex] Agentic Chat changes background on message and reset", async
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -83,7 +81,6 @@ test("[LlamaIndex] Agentic Chat retains memory of user messages during a convers
8381
);
8482

8583
const chat = new AgenticChatPage(page);
86-
await chat.openChat();
8784
await chat.agentGreeting.click();
8885

8986
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/mastraAgentLocalTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[MastraAgentLocal] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test("[MastraAgentLocal] Agentic Chat changes background on message and reset",
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -83,7 +81,6 @@ test("[MastraAgentLocal] Agentic Chat retains memory of user messages during a c
8381
);
8482

8583
const chat = new AgenticChatPage(page);
86-
await chat.openChat();
8784
await chat.agentGreeting.click();
8885

8986
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/mastraTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[Mastra] Agentic Chat sends and receives a greeting message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi");
2221

@@ -36,7 +35,6 @@ test("[Mastra] Agentic Chat provides weather information", async ({
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Ask for Islamabad weather
@@ -58,7 +56,6 @@ test("[Mastra] Agentic Chat retains memory of previous questions", async ({
5856
);
5957

6058
const chat = new AgenticChatPage(page);
61-
await chat.openChat();
6259
await chat.agentGreeting.waitFor({ state: "visible" });
6360

6461
// First question about weather
@@ -86,7 +83,6 @@ test("[Mastra] Agentic Chat retains memory of user messages during a conversatio
8683
);
8784

8885
const chat = new AgenticChatPage(page);
89-
await chat.openChat();
9086
await chat.agentGreeting.click();
9187

9288
await chat.sendMessage("Hey there");

typescript-sdk/apps/dojo/e2e/tests/middlewareStarterTests/agenticChatPage.spec.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@ test("[Middleware Starter] Testing Agentic Chat", async ({
1515
);
1616

1717
const chat = new AgenticChatPage(page);
18-
await chat.openChat();
1918
await chat.agentGreeting.waitFor({ state: "visible" });
2019
await chat.sendMessage("Hey there");
2120
await chat.assertUserMessageVisible("Hey there");

typescript-sdk/apps/dojo/e2e/tests/pydanticAITests/agenticChatPage.spec.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ test("[PydanticAI] Agentic Chat sends and receives a message", async ({
1616

1717
const chat = new AgenticChatPage(page);
1818

19-
await chat.openChat();
2019
await chat.agentGreeting.isVisible;
2120
await chat.sendMessage("Hi, I am duaa");
2221

@@ -36,7 +35,6 @@ test("[PydanticAI] Agentic Chat changes background on message and reset", async
3635

3736
const chat = new AgenticChatPage(page);
3837

39-
await chat.openChat();
4038
await chat.agentGreeting.waitFor({ state: "visible" });
4139

4240
// Store initial background color
@@ -83,7 +81,6 @@ test("[PydanticAI] Agentic Chat retains memory of user messages during a convers
8381
);
8482

8583
const chat = new AgenticChatPage(page);
86-
await chat.openChat();
8784
await chat.agentGreeting.click();
8885

8986
await chat.sendMessage("Hey there");

0 commit comments

Comments
 (0)