Skip to content

Commit c62826e

Browse files
committed
Verbosity is fine, try the clean reporter in CI
1 parent 3769b57 commit c62826e

File tree

1 file changed

+9
-25
lines changed

1 file changed

+9
-25
lines changed

typescript-sdk/apps/dojo/e2e/playwright.config.ts

Lines changed: 9 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ function getReporters(): ReporterDescription[] {
1111
uploadVideos: true,
1212
},
1313
];
14-
1514
const s3Reporter: ReporterDescription = [
1615
"./node_modules/playwright-slack-report/dist/src/SlackReporter.js",
1716
{
@@ -21,34 +20,19 @@ function getReporters(): ReporterDescription[] {
2120
layout: generateSimpleLayout, // Use our simple layout
2221
},
2322
];
24-
25-
let reporters: ReporterDescription[] = [];
23+
const githubReporter: ReporterDescription = ["github"];
24+
const htmlReporter: ReporterDescription = ["html", { open: "never" }];
25+
const cleanReporter: ReporterDescription = ["./clean-reporter.js"];
2626

2727
const addVideoAndSlack = process.env.SLACK_WEBHOOK_URL && process.env.AWS_S3_BUCKET_NAME;
28-
if (process.env.CI) {
29-
reporters = [
30-
["github"],
31-
["html", { open: "never" }],
32-
];
33-
if (addVideoAndSlack) {
34-
reporters.push(videoReporter, s3Reporter);
35-
}
36-
37-
return reporters;
38-
}
39-
40-
if (addVideoAndSlack) {
41-
return [
42-
videoReporter,
43-
s3Reporter,
44-
["html", { open: "never" }]
45-
];
46-
}
4728

4829
return [
49-
["./clean-reporter.js"],
50-
["html", { open: "never" }],
51-
];
30+
process.env.CI ? githubReporter : undefined,
31+
addVideoAndSlack ? videoReporter : undefined,
32+
addVideoAndSlack ? s3Reporter : undefined,
33+
htmlReporter,
34+
cleanReporter,
35+
].filter(Boolean) as ReporterDescription[];
5236
}
5337

5438
function getBaseUrl(): string {

0 commit comments

Comments
 (0)