fix: export subscriber type define #183
Open
+8
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qz1543706741
requested review from
mme,
ranst91,
ataibarkai,
maxkorp and
tylerslaton
as code owners
|
Is this going to be merged soon? |
tylerslaton
reviewed
Sep 11, 2025
There was a problem hiding this comment.
@mme What do you think?
@qz1543706741 would you mind rebasing so we can run our CI against this?
typescript-sdk/.npmrc
Outdated
There was a problem hiding this comment.
Can we please remove this?
There was a problem hiding this comment.
Can we please remove this?
I have fixed on commit f067412, thank u merge it soon @tylerslaton
There was a problem hiding this comment.
Thanks @qz1543706741, we're reviewing now. Things look good, just running the tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
export subscriber type define
[email protected] has not export these types
we should use type of gymnastics to get AgentSubscriberParams, such as