Fix tests

Author: joseivanlopez

service/lib/agama/manager.rb

@@ -231,7 +231,7 @@ def on_services_status_change(&block)
     #
     # @return [Boolean]
     def valid?
-      users.issues.empty? && !software.errors? && !storage.errors?
+      users.issues.empty? && !software.errors?
     end
 
     # Collects the logs and stores them into an archive

service/test/agama/dbus/clients/storage_test.rb

@@ -20,8 +20,6 @@
 # find current contact information at www.suse.com.
 
 require_relative "../../../test_helper"
-require_relative "with_issues_examples"
-require_relative "with_progress_examples"
 require "agama/dbus/clients/storage"
 require "dbus"
 
@@ -79,7 +77,4 @@
       subject.finish
     end
   end
-
-  include_examples "issues"
-  include_examples "progress"
 end

service/test/agama/manager_test.rb

@@ -58,7 +58,7 @@
   let(:storage) do
     instance_double(
       Agama::DBus::Clients::Storage, probe: nil, install: nil, finish: nil,
-      :product= => nil, errors?: false
+      :product= => nil
     )
   end
   let(:scripts) do
@@ -220,16 +220,6 @@
       end
     end
 
-    context "when there are storage errors" do
-      before do
-        allow(storage).to receive(:errors?).and_return(true)
-      end
-
-      it "returns false" do
-        expect(subject.valid?).to eq(false)
-      end
-    end
-
     context "when the software configuration is not valid" do
       before do
         allow(software).to receive(:errors?).and_return(true)