Skip to content

Commit 0f10897

Browse files
committed
Change from code review
1 parent 5280dc4 commit 0f10897

File tree

1 file changed

+6
-1
lines changed

1 file changed

+6
-1
lines changed

service/lib/agama/dbus/storage/manager.rb

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,6 +130,8 @@ def configure_product(id)
130130

131131
next_progress_step(CONFIGURING_STEP)
132132
calculate_proposal
133+
134+
finish_progress
133135
end
134136

135137
# Implementation for the API method #Install.
@@ -205,6 +207,8 @@ def configure(serialized_config)
205207

206208
config_json = JSON.parse(serialized_config, symbolize_names: true)
207209
calculate_proposal(config_json)
210+
211+
finish_progress
208212
end
209213

210214
# Applies the given serialized config model according to the JSON schema.
@@ -221,6 +225,8 @@ def configure_with_model(serialized_model)
221225
).convert
222226
config_json = { storage: Agama::Storage::ConfigConversions::ToJSON.new(config).convert }
223227
calculate_proposal(config_json)
228+
229+
finish_progress
224230
end
225231

226232
# Solves the given serialized config model.
@@ -399,7 +405,6 @@ def configure_with_current
399405
def calculate_proposal(config_json = nil)
400406
backend.configure(config_json)
401407
self.ProposalChanged(recover_proposal)
402-
finish_progress
403408
end
404409

405410
# JSON representation of the given devicegraph from StorageManager

0 commit comments

Comments
 (0)