feat(question): for "load.retry", unify action IDs from yes no to Yes No

while using with_action_ids

For consistency, apply the refactoring also to question test cases

Author: mvidner

rust/Cargo.lock

@@ -13,3 +13,4 @@ tempfile = "3.20.0"
 thiserror = "2.0.12"
 tokio = "1.46.0"
 url = "2.5.4"
+agama-l10n = { path = "../agama-l10n" }

rust/agama-autoinstall/Cargo.toml

@@ -20,6 +20,7 @@
 
 //! This module offers a mechanism to ask questions to users.
 
+use agama_l10n::helpers::gettext_noop;
 use agama_lib::{http::BaseHTTPClient, questions::http_client::HTTPClient as QuestionsHTTPClient};
 use agama_utils::api::question::QuestionSpec;
 
@@ -37,12 +38,12 @@ impl UserQuestions {
     /// Asks the user whether to retry loading the profile.
     pub async fn should_retry(&self, text: &str, error: &str) -> anyhow::Result<bool> {
         let question = QuestionSpec::new(text, "load.retry")
-            .with_actions(&[("yes", "Yes"), ("no", "No")])
-            .with_default_action("no")
+            .with_action_ids(&[gettext_noop("Yes"), gettext_noop("No")])
+            .with_default_action("No")
             .with_data(&[("error", error)]);
 
         let question = self.questions.create_question(&question).await?;
         let answer = self.questions.get_answer(question.id).await?;
-        Ok(answer.action == "yes")
+        Ok(answer.action == "Yes")
     }
 }

rust/agama-autoinstall/src/questions.rs

@@ -403,55 +403,55 @@ mod tests {
     fn test_string_question() {
         let q = QuestionSpec::new("Please, enter a username", "username")
             .as_string()
-            .with_actions(&[("next", "Next"), ("cancel", "Cancel")]);
+            .with_action_ids(&[gettext_noop("Next"), gettext_noop("Cancel")]);
 
         let q_str = serde_json::to_string_pretty(&q).unwrap();
         println!("{}", &q_str);
         assert!(matches!(q.field, QuestionField::String));
-        assert_eq!(q.actions[0], Action::new("next", "Next"));
-        assert_eq!(q.actions[1], Action::new("cancel", "Cancel"));
+        assert_eq!(q.actions[0], Action::new("Next", "Next"));
+        assert_eq!(q.actions[1], Action::new("Cancel", "Cancel"));
     }
 
     #[test]
     fn test_password_question() {
         let q = QuestionSpec::new("Decrypt the device", "luks")
             .as_password()
-            .with_actions(&[("decrypt", "Decrypt"), ("skip", "Skip")]);
+            .with_action_ids(&[gettext_noop("Decrypt"), gettext_noop("Skip")]);
 
         let q_str = serde_json::to_string_pretty(&q).unwrap();
         println!("{}", &q_str);
         assert!(matches!(q.field, QuestionField::Password));
-        assert_eq!(q.actions[0], Action::new("decrypt", "Decrypt"));
-        assert_eq!(q.actions[1], Action::new("skip", "Skip"));
+        assert_eq!(q.actions[0], Action::new("Decrypt", "Decrypt"));
+        assert_eq!(q.actions[1], Action::new("Skip", "Skip"));
     }
 
     #[test]
     fn test_select_question() {
         let q = QuestionSpec::new("There is a solver conflict...", "conflict")
             .as_select(&[("opt1", "Option 1"), ("opt2", "Option 2")])
-            .with_actions(&[("decrypt", "Decrypt"), ("skip", "Skip")]);
+            .with_action_ids(&[gettext_noop("Decrypt"), gettext_noop("Skip")]);
 
         let q_str = serde_json::to_string_pretty(&q).unwrap();
         println!("{}", &q_str);
         assert!(matches!(
             q.field,
             QuestionField::Select { options: _options }
         ));
-        assert_eq!(q.actions[0], Action::new("decrypt", "Decrypt"));
-        assert_eq!(q.actions[1], Action::new("skip", "Skip"));
+        assert_eq!(q.actions[0], Action::new("Decrypt", "Decrypt"));
+        assert_eq!(q.actions[1], Action::new("Skip", "Skip"));
     }
 
     #[test]
     fn test_answers_to() {
         let answer = Answer {
-            action: "cancel".to_string(),
+            action: "Cancel".to_string(),
             value: None,
         };
 
         let q = QuestionSpec::new("Please, enter a username", "username")
             .as_string()
             .with_data(&[("id", "1")])
-            .with_actions(&[("next", "Next"), ("cancel", "Cancel")]);
+            .with_action_ids(&[gettext_noop("Next"), gettext_noop("Cancel")]);
 
         let rule_by_text = AnswerRule {
             text: Some("Please, enter a username".to_string()),

rust/agama-utils/src/api/question.rs

@@ -44,14 +44,15 @@ mod tests {
             question::{Answer, AnswerRule, Config, Policy, QuestionSpec},
             Event,
         },
+        gettext_noop,
         question::{self, message},
     };
     use tokio::sync::broadcast;
 
     fn build_question_spec() -> QuestionSpec {
         QuestionSpec::new("Do you want to continue?", "continue")
-            .with_actions(&[("yes", "Yes"), ("no", "No")])
-            .with_default_action("no")
+            .with_action_ids(&[gettext_noop("Yes"), gettext_noop("No")])
+            .with_default_action("No")
     }
 
     #[tokio::test]
@@ -67,7 +68,7 @@ mod tests {
 
         // Answer the question
         let answer = Answer {
-            action: "yes".to_string(),
+            action: "Yes".to_string(),
             value: None,
         };
         questions
@@ -119,7 +120,7 @@ mod tests {
 
         // Define a rule and an answer.
         let answer = Answer {
-            action: "no".to_string(),
+            action: "No".to_string(),
             value: None,
         };
         let rule_by_class = AnswerRule {