Skip to content

Commit f6c9409

Browse files
committed
Still not seeing the favicon
1 parent 2f2dca5 commit f6c9409

File tree

5 files changed

+43
-21
lines changed

5 files changed

+43
-21
lines changed

README.md

Lines changed: 19 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -64,13 +64,8 @@ Follow the official instructions to test GitHub Pages sites with [Jekyll](https:
6464
plugins:
6565
- jekyll-gist
6666
```
67-
5. Open the _includes/elements/github_edit_footer.html file and leave it empty to avoid errors while testing locally. Later, when the repository is finished and public, you can add the following content:
68-
```html
69-
<footer class="github-footer">
70-
This page is <b>open source</b>. Noticed a typo? <br />
71-
Or something unclear? {% github_edit_link "Improve it on GitHub" %}.
72-
</footer>
73-
```
67+
5. Open the problematic file _includes/ file and leave it empty to avoid errors while testing locally. Later, when the repository is finished and public, you can add the previous content.
68+
7469
6. Install the dependencies with:
7570
```bash
7671
bundle install
@@ -86,9 +81,23 @@ Follow the official instructions to test GitHub Pages sites with [Jekyll](https:
8681
### Done!
8782
You can now access your website locally at http://127.0.0.1:4000. If you encounter any issues, check the _config.yml and Gemfile, or refer to the official Jekyll documentation.
8883

89-
90-
91-
84+
A typicall organized structure of a Jeckyll project may be something like this:
85+
```
86+
├── assets/ # Static files
87+
│ ├── css/ # CSS stylesheets
88+
│ ├── js/ # JavaScript files
89+
│ ├── images/ # Images for the site
90+
│ └── favicon.ico # Site favicon
91+
├── _config.yml # Site configuration file
92+
├── _data/ # Data files (YAML/JSON/CSV)
93+
├── _includes/ # Reusable HTML snippets
94+
├── _layouts/ # Base templates (HTML)
95+
├── pages/ # Static pages (like about, contact, etc.)
96+
├── _posts/ # Blog posts
97+
├── _projects/ # Projects (portfolio items)
98+
├── _sass/ # Sass style fragments
99+
└── _site/ # Output generated by Jekyll (DO NOT EDIT)
100+
```
92101

93102

94103

_config.yml

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,30 @@
1+
### Site Settings ###
2+
source : ./ ## Indica la raíz de tu proyecto. Jekyll busca aquí todo el contenido y los archivos necesarios para generar el sitio
3+
14
### Site Settings ###
25
title : agarnung.github.io
36
description : >-
47
My personal portfolio.
8+
9+
# URL base donde se aloja el sitio:
510
#baseurl : "/portfolYOU" # Change to empty quotes if you are hosting your site at <your-username>.github.io directly
611
baseurl: "" # Empty for local development
12+
713
#repository : yousinix/portfolYOU # Change to <your-username>/<your-username>.github.io (or remove it if you don't need remote projects)
8-
remote_theme : agarnung/agarnung
9-
open_new_tab : false # Opens external URLs in new tab (works for posts, projects and navbar only)
14+
#remote_theme : agarnung/agarnung
15+
open_new_tab : true # Opens external URLs (<a href="...">) in new tab (works for posts, projects and navbar only)
1016

17+
# URL completa del sitio:
18+
url: "" # Empty for local development
19+
url: "https://agarnung.github.io " # En producción
1120

1221
### Plugins ###
1322
plugins:
1423
- jemoji
1524

16-
#github:
17-
# - repo: agarnung/agarnung.github.io
18-
# - branch: main
25+
github:
26+
- repo: agarnung/agarnung.github.io
27+
- branch: main
1928

2029
### Navbar Settings ###
2130
nav_exclude: # The following paths are excluded from navbar
Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,4 @@
1+
<--<footer class="github-footer">
2+
This page is <b>open source</b>. Noticed a typo? <br />
3+
Or something unclear? {% github_edit_link "Improve it on GitHub" %}.
4+
</footer>-->

_site/blog/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ <h3 class="card-title">What is version control?</h3>
269269
</div>
270270

271271
<div class="col-lg-6 my-3 wow animated fadeIn" data-wow-delay=".15s">
272-
<a href="https://blog.usejournal.com/how-to-undo-your-git-failure-b76e31ecac74" class="post card bg-warning">
272+
<a href="https://blog.usejournal.com/how-to-undo-your-git-failure-b76e31ecac74" class="post card bg-warning"target="_blank">
273273
<div class="card-body text-white">
274274
<h3 class="card-title">How to undo your git failure?</h3>
275275
<p class="card-text">

_site/projects/index.html

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@
8181

8282
<!-- Local Projects -->
8383
<div class="wow animated fadeIn" data-wow-delay=".15s">
84-
<a href="https://www.google.com" class="project card text-themed"><img id="placeholder-project-img" class="card-img-top" src="https://www.sketchappsources.com/resources/source-image/project-neon-groove-music-ui.png" alt="PlaceHolder Project" /><div class="card-body">
84+
<a href="https://www.google.com" class="project card text-themed"target="_blank"><img id="placeholder-project-img" class="card-img-top" src="https://www.sketchappsources.com/resources/source-image/project-neon-groove-music-ui.png" alt="PlaceHolder Project" /><div class="card-body">
8585
<h5 id="placeholder-project-name" class="card-title">PlaceHolder Project
8686
</h5>
8787
<p id="placeholder-project-desc" class="card-text">Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>
@@ -101,7 +101,7 @@ <h5 id="the-movies-project-name" class="card-title">The Movies Project
101101
</div>
102102

103103
<div class="wow animated fadeIn" data-wow-delay=".15s">
104-
<a href="https://github.com/yousinix" class="project card text-themed"><div class="card-body">
104+
<a href="https://github.com/yousinix" class="project card text-themed"target="_blank"><div class="card-body">
105105
<h5 id="empty-project-name" class="card-title">Empty Project
106106
</h5>
107107
<p id="empty-project-desc" class="card-text">This project has no image or showcase page, but it is still a beautiful project inside out!</p>
@@ -111,7 +111,7 @@ <h5 id="empty-project-name" class="card-title">Empty Project
111111
</div>
112112

113113
<div class="wow animated fadeIn" data-wow-delay=".15s">
114-
<a href="https://github.com/yousinix" class="project card text-themed"><div class="card-body">
114+
<a href="https://github.com/yousinix" class="project card text-themed"target="_blank"><div class="card-body">
115115
<h5 id="coding-like-vincent-van-gogh-name" class="card-title">Coding Like Vincent Van Gogh
116116
</h5>
117117
<p id="coding-like-vincent-van-gogh-desc" class="card-text">Show some support by following me!</p>
@@ -121,7 +121,7 @@ <h5 id="coding-like-vincent-van-gogh-name" class="card-title">Coding Like Vincen
121121
</div>
122122

123123
<div class="wow animated fadeIn" data-wow-delay=".15s">
124-
<a href="https://thefabulous.co/" class="project card text-themed"><img id="the-fabulous-img" class="card-img-top" src="https://storage.googleapis.com/gd-wagtail-prod-assets/original_images/material_design_awards_inline_002.jpg" alt="The Fabulous" /><div class="card-body">
124+
<a href="https://thefabulous.co/" class="project card text-themed"target="_blank"><img id="the-fabulous-img" class="card-img-top" src="https://storage.googleapis.com/gd-wagtail-prod-assets/original_images/material_design_awards_inline_002.jpg" alt="The Fabulous" /><div class="card-body">
125125
<h5 id="the-fabulous-name" class="card-title">The Fabulous
126126
</h5>
127127
<p id="the-fabulous-desc" class="card-text">Fabulous is a science-based app, incubated in Duke's Behavioral Economics Lab, that will help you build healthy rituals into your life, just like an elite athlete.</p>
@@ -131,7 +131,7 @@ <h5 id="the-fabulous-name" class="card-title">The Fabulous
131131
</div>
132132

133133
<div class="wow animated fadeIn" data-wow-delay=".15s">
134-
<a href="https://www.google.com" class="project card text-themed"><img id="dummy-project-img" class="card-img-top" src="https://www.sketchappsources.com/resources/source-image/coo-app-concept-subgaurav.jpg" alt="Dummy Project" /><div class="card-body">
134+
<a href="https://www.google.com" class="project card text-themed"target="_blank"><img id="dummy-project-img" class="card-img-top" src="https://www.sketchappsources.com/resources/source-image/coo-app-concept-subgaurav.jpg" alt="Dummy Project" /><div class="card-body">
135135
<h5 id="dummy-project-name" class="card-title">Dummy Project
136136
</h5>
137137
<p id="dummy-project-desc" class="card-text">Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.</p>

0 commit comments

Comments
 (0)