CMake: don't set INTERFACE_LINK_LIBRARIES for the static version of libOpenCOR.

Author: agarny

cmake/formatting/CMakeLists.txt

@@ -25,13 +25,13 @@ if(FORMAT_CODE_AVAILABLE)
         ${GIT_TESTS_HEADER_FILES}
     )
 
-    set(CODE_FORMATTING_SCRIPT ${CMAKE_CURRENT_BINARY_DIR}/codeformatting.cmake)
+    set(CODE_FORMATTING_CMAKE_FILE ${CMAKE_CURRENT_BINARY_DIR}/codeformatting.cmake)
 
-    configure_file(codeformatting.cmake.in ${CODE_FORMATTING_SCRIPT} @ONLY)
+    configure_file(codeformatting.cmake.in ${CODE_FORMATTING_CMAKE_FILE} @ONLY)
 
     if(CHECK_CODE_FORMATTING_AVAILABLE)
         add_target(check_code_formatting
-                   COMMAND ${CMAKE_COMMAND} -P ${CODE_FORMATTING_SCRIPT}
+                   COMMAND ${CMAKE_COMMAND} -P ${CODE_FORMATTING_CMAKE_FILE}
                    COMMENT "Checking code formatting...")
     endif()
 

cmake/packaging/patch.cmake.in

@@ -0,0 +1,6 @@
+file(GLOB_RECURSE CMAKE_FILE "@CMAKE_PROJECT_NAME@Targets.cmake")
+file(READ ${CMAKE_FILE} FILE_CONTENTS)
+
+string(REGEX REPLACE "\n[^\n]*INTERFACE_LINK_LIBRARIES[^\n]*\n" "\n" FILE_CONTENTS "${FILE_CONTENTS}")
+
+file(WRITE ${CMAKE_FILE} "${FILE_CONTENTS}")

src/CMakeLists.txt

@@ -328,7 +328,7 @@ else()
 
         set(PACKAGES_DIR ${CMAKE_BINARY_DIR}/packages)
 
-        file(GLOB_RECURSE PACKAGES "${PREBUILT_DIR}/*${CMAKE_STATIC_LIBRARY_SUFFIX}")
+        file(GLOB_RECURSE PACKAGES ${PREBUILT_DIR}/*${CMAKE_STATIC_LIBRARY_SUFFIX})
 
         # Extract the object files from our various packages.
 
@@ -497,6 +497,23 @@ else()
     set(CMAKE_PACKAGE_DIR lib/cmake/${CMAKE_PROJECT_NAME})
 endif()
 
+if(NOT LIBOPENCOR_SHARED_LIBS)
+    # Patch the generated libOpenCORTargets.cmake file by removing the INTERFACE_LINK_LIBRARIES line. Indeed, it lists
+    # all the third-party libraries used by libOpenCOR. However, the way we build the static version of libOpenCOR (so
+    # that it embeds all of its dependencies) means that we don't need and, in fact, don't want to list them. (Don't
+    # want because otherwise CMake might complain that it cannot find libOpenCOR's "dependencies".)
+    # Note: rather than patching libOpenCORTargets.cmake, we could use
+    #         set_target_properties(${CMAKE_PROJECT_NAME} PROPERTIES INTERFACE_LINK_LIBRARIES "")
+    #       but this will fail our Python bindings. So, we patch libOpenCORTargets.cmake instead.
+
+    set(PATCH_CMAKE_FILE ${CMAKE_CURRENT_BINARY_DIR}/patch.cmake)
+
+    configure_file(${PROJECT_SOURCE_DIR}/cmake/packaging/patch.cmake.in ${PATCH_CMAKE_FILE} @ONLY)
+
+    add_custom_command(TARGET ${CMAKE_PROJECT_NAME} PRE_BUILD
+                       COMMAND ${CMAKE_COMMAND} -P ${PATCH_CMAKE_FILE})
+endif()
+
 install(EXPORT ${CMAKE_PROJECT_NAME}Targets
         FILE ${CMAKE_PROJECT_NAME}Targets.cmake
         DESTINATION ${CMAKE_PACKAGE_DIR})