Remove unittest TestCases, switch to pytest style for assertions

Author: agateblue

requirements-test.txt

@@ -10,3 +10,4 @@ pytest-cov
 pytest-django
 pytest-sugar
 django-nose
+ipdb

tests/conftest.py

@@ -0,0 +1,56 @@
+import pytest
+
+from django.core import cache as django_cache
+from django.contrib.auth.models import User
+
+@pytest.fixture(autouse=True)
+def cache():
+    django_cache.cache.clear()
+    yield django_cache.cache
+
+
+@pytest.fixture
+def assert_redirect():
+    def inner(response, expected):
+        assert response.status_code == 302
+        assert response['Location'] == expected
+    
+    return inner
+
+
+
+
+@pytest.fixture
+def fake_user(db):
+    return User.objects.create_user(username="test", password="test", email="[email protected]")
+
+@pytest.fixture
+def fake_admin(db):
+    return User.objects.create_user(
+        username="admin", email="[email protected]", password="test", is_superuser=True, is_staff=True
+    )
+
+
+@pytest.fixture
+def admin_client(client, fake_admin):
+    assert client.login(username="admin", password="test") is True
+    return client
+
+
+@pytest.fixture
+def user_client(client, fake_user):
+    assert client.login(username="test", password="test") is True
+    return client
+
+
+@pytest.fixture
+def henri(db):
+    return User.objects.create_user(
+        username="henri", password="test", email="[email protected]"
+    )
+
+
+@pytest.fixture
+def henri_client(client, henri):
+    assert client.login(username="henri", password="test") is True
+    return client

tests/test_checkpreferences_command.py

@@ -5,40 +5,39 @@
 from django.test import TestCase
 
 
-class BaseTest(object):
-
-    def tearDown(self):
-        caches["default"].clear()
-
-
-class TestCheckPreferencesCommand(BaseTest, TestCase):
-    def call_command(self, *args, **kwargs):
-        out = StringIO()
-        call_command(
-            "checkpreferences",
-            *args,
-            stdout=out,
-            stderr=StringIO(),
-            **kwargs,
-        )
-        return out.getvalue().strip()
-
-    def test_dry_run(self):
-        out = self.call_command(verbosity=0)
-        expected_output = "\n".join([
+def call(*args, **kwargs):
+    out = StringIO()
+    call_command(
+        "checkpreferences",
+        *args,
+        stdout=out,
+        stderr=StringIO(),
+        **kwargs,
+    )
+    return out.getvalue().strip()
+
+
+def test_dry_run(db):
+    out = call(verbosity=0)
+    expected_output = "\n".join(
+        [
             "Creating missing global preferences...",
             "Deleted 0 global preferences",
             "Deleted 0 GlobalPreferenceModel preferences",
             "Deleted 0 UserPreferenceModel preferences",
             "Creating missing preferences for User model...",
-        ])
-        self.assertEqual(out, expected_output)
+        ]
+    )
+    assert out == expected_output
+
 
-    def test_skip_create(self):
-        out = self.call_command("--skip_create", verbosity=0)
-        expected_output = "\n".join([
+def test_skip_create(db):
+    out = call("--skip_create", verbosity=0)
+    expected_output = "\n".join(
+        [
             "Deleted 0 global preferences",
             "Deleted 0 GlobalPreferenceModel preferences",
             "Deleted 0 UserPreferenceModel preferences",
-        ])
-        self.assertEqual(out, expected_output)
+        ]
+    )
+    assert out == expected_output