added test if preference is pickleable

Author: mihalikv

dynamic_preferences/serializers.py

@@ -285,6 +285,7 @@ class FakeInstance(object):
     def save(self):
         return
 
+
 class FakeField(object):
     """
     FieldFile needs a field object to generate a filename, persist
@@ -295,9 +296,6 @@ class FakeField(object):
     attname = "noop"
     max_length = 10000
 
-    def generate_filename(field, instance, name):
-        return os.path.join(self.preference.get_upload_path(), f.name)
-
 
 class PreferenceFieldFile(FieldFile):
     """
@@ -483,5 +481,5 @@ def to_python(cls, value, **kwargs):
         while "" in ret:
             pos = ret.index("")
             val = ret[pos - 1] + cls.separator + ret[pos + 1]
-            ret = ret[0 : pos - 1] + [val] + ret[pos + 2 :]
+            ret = ret[0: pos - 1] + [val] + ret[pos + 2:]
         return ret

tests/test_types.py

@@ -1,5 +1,7 @@
 import os
 import decimal
+import pickle
+
 import pytest
 
 from datetime import date, timedelta, datetime, time
@@ -239,6 +241,19 @@ def test_file_preference_api_repr_returns_path(db):
     assert p.api_repr(f) == f.url
 
 
+def test_file_preference_if_pickleable(db):
+    manager = global_preferences_registry.manager()
+    f = SimpleUploadedFile(
+        "test_file_24485a80-8db9-4191-ae49-da7fe2013794.txt",
+        "hello world".encode("utf-8"),
+    )
+    try:
+        manager["blog__logo"] = f
+        pickle.dumps(manager["blog__logo"])
+    except Exception:
+        pytest.fail("FilePreference not pickleable")
+
+
 def test_choice_preference(fake_user):
     fake_user.preferences["user__favorite_vegetable"] = "C"
     assert fake_user.preferences["user__favorite_vegetable"] == "C"