Introduce cargo machete to remove unused deps (quickwit-oss#6067)

* introduce cargo machete

* add machete to CI

* fix doc

* update machete

* update contributing.md

* update checking machete command

Author: congx4

.github/workflows/ci.yml

@@ -145,6 +145,11 @@ jobs:
         with:
           # 0.18 requires rustc 1.85
           tool: cargo-deny@0.17.0
+      - name: Install cargo machete
+        if: always() && steps.modified.outputs.rust_src == 'true'
+        uses: taiki-e/cache-cargo-install-action@7447f04c51f2ba27ca35e7f1e28fab848c5b3ba7 # v2.3.1
+        with:
+          tool: cargo-machete
       - name: cargo clippy
         if: always() && steps.modified.outputs.rust_src == 'true'
         run: cargo clippy --workspace --tests --all-features
@@ -153,6 +158,10 @@ jobs:
         if: always() && steps.modified.outputs.rust_src == 'true'
         run: cargo deny check licenses
         working-directory: ./quickwit
+      - name: cargo machete
+        if: always() && steps.modified.outputs.rust_src == 'true'
+        run: cargo machete
+        working-directory: ./quickwit
       - name: cargo doc
         if: always() && steps.modified.outputs.rust_src == 'true'
         run: cargo doc

CONTRIBUTING.md

@@ -48,7 +48,7 @@ Run `make test-all` to run all tests.
 * `make test-all` - starts necessary Docker services and runs all tests.
 * `make -k test-all docker-compose-down` - the same as above, but tears down the Docker services after running all the tests.
 * `make fmt` - runs formatter, this command requires the nightly toolchain to be installed by running `rustup toolchain install nightly`.
-* `make fix` - runs formatter and clippy checks.
+* `make fix` - runs formatter and clippy checks as well as removing unused dependencies (requires `cargo install cargo-machete`).
 * `make typos` - runs the spellcheck tool over the codebase. (Install by running `cargo install typos-cli`)
 * `make doc` - builds docs.
 * `make docker-compose-up` - starts Docker services.

quickwit/Cargo.lock

@@ -21,6 +21,12 @@ fix:
 	@echo "Running cargo clippy --fix"
 	@cargo clippy --workspace --all-features --tests --fix --allow-dirty --allow-staged
 	@$(MAKE) fmt
+	@$(MAKE) unused-deps
+
+unused-deps:
+	@echo "Checking for unused dependencies"
+	@(command -v cargo-machete >/dev/null || cargo --list | grep -q machete || (echo "cargo-machete is not installed. Please install using 'cargo install cargo-machete'." && exit 1))
+	@cargo machete
 
 # Usage:
 # `make test-all` starts the Docker services and runs all the tests.

quickwit/Makefile

@@ -17,14 +17,7 @@ aws-sdk-kinesis = { workspace = true, optional = true }
 aws-sdk-s3 = { workspace = true }
 aws-sdk-sqs = { workspace = true, optional = true }
 aws-smithy-async = { workspace = true }
-aws-smithy-http-client = { workspace = true }
-aws-smithy-runtime = { workspace = true }
-aws-types = { workspace = true }
-
 futures = { workspace = true }
-http-body-util = { workspace = true }
-hyper = { workspace = true }
-hyper-rustls = { workspace = true }
 tokio = { workspace = true }
 
 quickwit-common = { workspace = true }

quickwit/quickwit-aws/Cargo.toml

@@ -18,7 +18,6 @@ proc-macro2 = { workspace = true }
 prost-build = { workspace = true }
 quote = { workspace = true }
 syn = { workspace = true }
-tonic-build = { workspace = true }
 tonic-prost-build = { workspace = true }
 
 [dev-dependencies]

quickwit/quickwit-codegen/Cargo.toml

@@ -39,7 +39,6 @@ siphasher = { workspace = true }
 sysinfo = { workspace = true }
 tempfile = { workspace = true }
 thiserror = { workspace = true }
-tikv-jemalloc-ctl = { workspace = true, optional = true }
 tikv-jemallocator = { workspace = true, optional = true }
 tokio = { workspace = true }
 tokio-metrics = { workspace = true }
@@ -59,7 +58,6 @@ jemalloc-profiled = [
     "named_tasks",
     "dep:backtrace",
     "dep:tikv-jemallocator",
-    "dep:tikv-jemalloc-ctl",
 ]
 
 [dev-dependencies]

quickwit/quickwit-common/Cargo.toml

@@ -24,9 +24,7 @@ rand = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }
 smallvec = { workspace = true }
-time = { workspace = true }
 tokio = { workspace = true }
-tower = { workspace = true }
 tracing = { workspace = true }
 ulid = { workspace = true }
 

quickwit/quickwit-control-plane/Cargo.toml

@@ -11,7 +11,6 @@ authors.workspace = true
 license.workspace = true
 
 [dependencies]
-anyhow = { workspace = true }
 itertools = { workspace = true }
 serde = { workspace = true }
 serde_json = { workspace = true }

quickwit/quickwit-datetime/Cargo.toml

@@ -18,7 +18,6 @@ bytesize = { workspace = true }
 fail = { workspace = true, optional = true }
 futures = { workspace = true }
 http = { workspace = true }
-itertools = { workspace = true }
 mockall = { workspace = true, optional = true }
 mrecordlog = { workspace = true }
 once_cell = { workspace = true }