chore: sync core lib and CLAUDE.md from agent-core (#267)

avifenesh · agent-core-bot · web-flow · commit 0146f0ef8563 · 2026-02-22T03:15:15.000+02:00
* chore: sync core lib and CLAUDE.md from agent-core * fix: address review comments and failing tests - Expand CLAUDE.md rule #7 with detailed body text (fixes 3 test assertions) - Remove auto-generated comment from CLAUDE.md - Clean up dead requires/core code in bin/cli.js to match schema removal --------- Co-authored-by: agent-core-bot <noreply@agent-sh.github.io>
diff --git a/CLAUDE.md b/CLAUDE.md
@@ -1,267 +1,58 @@
-# Project Memory: AgentSys
+# agentsys
 
-> **Cross-tool compatible**: This file works as CLAUDE.md (Claude Code) and can be copied to AGENTS.md for OpenCode, Codex, and other AI tools.
+> A modular runtime and orchestration system for AI agents - works with Claude Code, OpenCode, and Codex CLI
 
-<project-memory>
+## Critical Rules
 
-<critical-rules>
-## Critical Rules (Priority Order)
-
-1. **Production project** - Real users depend on this. Test thoroughly and verify all edge cases before committing.
-   *WHY: Breaking changes affect all plugin users immediately.*
-
-2. **Plugin for OTHER projects** - Optimize for plugin users, not internal dev convenience.
-   *WHY: Every decision must improve the experience for developers using this in their repos.*
-
-3. **Use CHANGELOG.md for completion tracking** - MUST use CHANGELOG.md for release notes. NEVER create `*_AUDIT.md`, `*_SUMMARY.md`, `*_COMPLETION.md` files.
-   *WHY: Summary files clutter repos and add no value. Report completion verbally.*
-
-4. **Unless** it is a very small change of max few lines, or an urgent hotfix, **MUST create PRs for all changes** - No direct pushes to main.
-   *WHY: PRs enable reviews, CI checks, and rollback if needed. Direct pushes are risky.*
-
-5. **PR reviews** - Wait 3 min for auto-reviewers, address ALL comments (Copilot, Claude, Gemini, Codex).
-   *WHY: Skipping comments leads to merged issues. Every comment must be addressed or explained.*
-
-6. **Read checklists BEFORE multi-file changes** - **MUST** read the relevant checklist before starting:
-   - **Cross-platform work → `checklists/cross-platform-compatibility.md`** (MASTER REF)
-   - Release → `checklists/release.md`
-   - New command → `checklists/new-command.md`
-   - New agent → `checklists/new-agent.md`
-   - New skill → `checklists/new-skill.md`
-   - New lib module → `checklists/new-lib-module.md`
-   - OpenCode plugin update → `checklists/update-opencode-plugin.md`
-   - Repo map changes → `checklists/repo-map.md`
-   *WHY: Multi-file changes have hidden dependencies. Checklists prevent missed updates.*
-
-7. **Especially Before release, and when delivering ANY work** - Check the relevant checklist for completion requirements:
-   - Identify which checklist applies to your work (see rule #6)
-   - Go through EVERY item in that checklist and apply it (e.g. run commands, which files to bump versions in, etc)
-   - Run the `/enhance` command on new or modified commands, agents, skills, hooks or prompts
-   - Verify cross-platform compatibility (OpenCode + Codex)
-   - Update `bin/cli.js` mappings if new command/agent added
-   - Only mark complete after ALL checklist items are done
-   *WHY: Checklists exist because we kept missing things. They are the definition of "done".*
-
-8. **Use plain text markers** - MUST use `[OK]`, `[ERROR]`, `[WARN]`, `[CRITICAL]` for status. NEVER use emojis or ASCII art boxes.
-   - Save tokens - conciseness and clarity over decorations
-   - Use markdown formatting instead of decorative borders
-   *WHY: Emojis and ASCII art waste tokens. AI models parse plain text better.*
-
-9. **gh/git on Windows** - Escape `$` as `\$` in GraphQL queries, avoid `!=` in jq (use `== "A" or == "B"`).
-   - `gh pr checks` uses `state` not `conclusion` - returns UPPERCASE: `SUCCESS`, `FAILURE`, `PENDING`
-   - Single quotes unreliable - use double quotes with escaped inner quotes
-   *WHY: Windows shell interprets $ and ! differently. These cause silent failures.*
-
-10. **Always run git hooks** - Run all pre-commit and pre-push hooks. If a hook blocks, fix the reported issue.
-   - Hooks catch problems before they reach the repo
-   - Fix the root cause, then retry
-   *WHY: Hooks are safety nets. Bypassing them defeats their purpose.*
-
-11. **Argument hints use `[]` not `<>`** - In `argument-hint` frontmatter, use `[arg]` for optional args, not `<arg>`.
-   - Correct: `argument-hint: "[path] [--fix] [--target [target]]"`
-   - Wrong: `argument-hint: "[path] [--fix] [--target <target>]"`
-   *WHY: Consistent with Claude Code conventions. Angle brackets are ambiguous.*
-
-12. **Fix all test failures** - NEVER skip or ignore a failing test because it's "out of scope" or "pre-existing". Always fix it.
-   - If a test fails during your work, fix it before proceeding
-   - No test is someone else's problem
-   *WHY: Skipping failures erodes test trust. Every green run must mean everything works.*
-
-13. **Report script failures before manual fallback** - When any project script fails (npm test/run/build, scripts/*, agentsys-dev, node bin/dev-cli.js), you MUST:
+1. **Plain text output** - No emojis, no ASCII art. Use `[OK]`, `[ERROR]`, `[WARN]`, `[CRITICAL]` for status markers.
+2. **No unnecessary files** - Don't create summary files, plan files, audit files, or temp docs.
+3. **Task is not done until tests pass** - Every feature/fix must have quality tests.
+4. **Create PRs for non-trivial changes** - No direct pushes to main.
+5. **Always run git hooks** - Never bypass pre-commit or pre-push hooks.
+6. **Use single dash for em-dashes** - In prose, use ` - ` (single dash with spaces), never ` -- `.
+7. **Report script failures before manual fallback** - When any project script fails (npm test/run/build, scripts/*, agentsys-dev, node bin/dev-cli.js), you MUST:
    - Report the failure with exact error output to the user
    - Diagnose the root cause of the failure
    - Fix the script/tooling issue, not work around it manually
    - NEVER silently fall back to doing the work by hand
-   *WHY: Silent fallbacks mask broken tooling. A failed script needs fixing, not bypassing.*
-</critical-rules>
-
-<architecture>
-## Architecture
+8. **Token efficiency** - Be concise. Save tokens over decorations.
 
-<!-- GEN:START:claude-architecture -->
-```
-lib/          → Shared library (vendored to plugins)
-plugins/      → 0 plugins, 10 agents (0 file-based + 10 role-based), 0 skills
-adapters/     → Platform adapters (opencode-plugin/, opencode/, codex/)
-checklists/   → Action checklists (9 files)
-bin/cli.js    → npm CLI installer
-```
+## Model Selection
 
-| Plugin | Agents | Skills | Purpose |
-|--------|--------|--------|---------|
-<!-- GEN:END:claude-architecture -->
+| Model | When to Use |
+|-------|-------------|
+| **Opus** | Complex reasoning, analysis, planning |
+| **Sonnet** | Validation, pattern matching, most agents |
+| **Haiku** | Mechanical execution, no judgment needed |
 
-> Note: `plugins/ → 0 plugins` is correct — all 14 plugins now live in standalone repos under
-> the [agent-sh](https://github.com/agent-sh) org. The ecosystem-wide counts (14 plugins,
-> 43 agents, 30 skills) reflect all repos combined. agentsys is the marketplace and installer.
+## Core Priorities
 
-**Pattern**: `Command → Agent → Skill` (orchestration → invocation → implementation)
-</architecture>
+1. User DX (plugin users first)
+2. Worry-free automation
+3. Token efficiency
+4. Quality output
+5. Simplicity
 
-<commands>
 ## Commands
 
-### Core Workflow
-- `/next-task` - Master workflow: task → implementation → PR → merge
+- `/next-task` - Task workflow: discovery, implementation, PR, merge
 - `/ship` - PR creation, CI monitoring, merge
-- `/enhance` - Run all enhancement analyzers
-
-### Analysis
+- `/enhance` - Run enhancement analyzers
 - `/audit-project` - Multi-agent code review
 - `/deslop` - Clean AI slop patterns
 - `/drift-detect` - Compare plan vs implementation
 - `/perf` - Performance investigation
 - `/repo-map` - Generate AST-based repo map
-
-### Learning
-- `/learn` - Research topic online, create learning guide with RAG index
-
-### Linting
-- `/agnix` - Lint agent configs (SKILL.md, CLAUDE.md, hooks, MCP)
-
-### Maintenance
 - `/sync-docs` - Update documentation to match code
 
-### Dev Commands
-```bash
-# Local dev CLI (when developing agentsys itself)
-npx agentsys-dev status           # Project health (version, counts, branch)
-npx agentsys-dev validate         # Run all validators
-npx agentsys-dev validate plugins # Run single validator
-npx agentsys-dev bump <version>   # Bump all version files (e.g., 3.7.3)
-npx agentsys-dev test             # Run test suite
-npx agentsys-dev preflight         # Change-aware checklist enforcement
-npx agentsys-dev preflight --all   # Run all checks
-npx agentsys-dev preflight --release # All checks + release extras
-npx agentsys-dev gen-docs          # Auto-generate doc sections
-npx agentsys-dev gen-docs --check  # Validate docs are fresh (CI)
-npx agentsys-dev expand-templates  # Expand template markers in agents
-npx agentsys-dev expand-templates --check # Validate templates are fresh (CI)
-npx agentsys-dev new plugin <name>  # Scaffold new plugin
-npx agentsys-dev new agent <name> --plugin=<plugin>  # Scaffold new agent
-npx agentsys-dev new skill <name> --plugin=<plugin>  # Scaffold new skill
-npx agentsys-dev new command <name> --plugin=<plugin>  # Scaffold new command
-npx agentsys-dev --help           # Show all commands
-
-# Alternative: direct invocation
-node bin/dev-cli.js <command>
+## Dev Commands
 
-# npm aliases still work:
-npm test                     # Run tests (do before commits)
-npm run validate             # All validators via dev-cli
-npm run preflight            # Change-aware preflight checks
-npm run preflight:all        # All preflight checks
-npm run preflight:release    # Release preflight
-npm run gen-docs             # Auto-generate documentation
-npm run gen-docs:check       # Check if docs are stale
-npm run expand-templates     # Expand agent templates
-npm run expand-templates:check # Check if templates are stale
-npm run new:plugin           # Scaffold new plugin
-npm run new:agent            # Scaffold new agent
-npm run new:skill            # Scaffold new skill
-npm run new:command          # Scaffold new command
-npm run bump <version>       # Bump versions via dev-cli
-npm pack                     # Build package
-agentsys                # Run installer
+```bash
+npm test          # Run tests
+npm run validate  # All validators
 ```
-</commands>
-
-<agents>
-## Agents
-
-40 agents across 11 plugins. Key agents by model:
-
-| Model | Agents | Use Case |
-|-------|--------|----------|
-| **opus** | planning, implementation, perf-orchestrator, debate-orchestrator | Complex reasoning, judgment |
-| **sonnet** | exploration, learn, task-discoverer, delivery-validator, ci-fixer, deslop-agent, reporters | Validation, pattern matching |
-| **haiku** | worktree-manager, ci-monitor, simple-fixer | Mechanical execution |
-
-See [README.md](./README.md#command-details) and [docs/reference/AGENTS.md](./docs/reference/AGENTS.md) for full agent list.
-</agents>
-
-<skills>
-## Skills
-
-26 skills across plugins. Agents invoke skills for reusable implementation.
-
-| Category | Key Skills |
-|----------|------------|
-| Workflow | `orchestrate-review`, `discover-tasks`, `validate-delivery` |
-| Enhancement | `enhance-*` (9 skills for plugins, agents, docs, prompts, hooks) |
-| Performance | `baseline`, `benchmark`, `profile`, `theory-tester` |
-| Cleanup | `deslop`, `sync-docs`, `drift-analysis`, `repo-mapping` |
-
-See [README.md](./README.md#skills) for full skill list.
-</skills>
-
-<state-files>
-## State Files
-
-| File | Location | Purpose |
-|------|----------|---------|
-| `tasks.json` | `{stateDir}/` | Active task registry |
-| `flow.json` | `{stateDir}/` (worktree) | Workflow progress |
-| `preference.json` | `{stateDir}/sources/` | Cached task source |
-| `suppressions.json` | `~/.<claude\|opencode\|codex>/enhance/` | Auto-learned suppressions |
-
-Platform-aware state directory:
-- Claude Code: `.claude/`
-- OpenCode: `config/.opencode/`
-- Codex: `.codex/`
-</state-files>
-
-<workflow-agents>
-## Workflow Agents (MUST-CALL)
-
-Cannot skip in /next-task:
-- `exploration-agent` → before planning
-- `planning-agent` → before implementation
-- **Phase 9 review loop** → MUST use orchestrate-review skill
-- `delivery-validator` → before sync-docs:sync-docs-agent
-- `sync-docs:sync-docs-agent` → before /ship
-</workflow-agents>
-
-<pr-auto-review>
-## PR Auto-Review
-
-4 reviewers: Copilot, Claude, Gemini, Codex
-
-1. Wait 3 min after PR creation (initial auto-reviews)
-2. Claude-review may take 10+ min - wait for it
-3. Read ALL comments
-4. Address EVERY comment
-5. Iterate until zero unresolved
-</pr-auto-review>
-
-<model-selection>
-## Model Selection
-
-| Model | When to Use |
-|-------|-------------|
-| **Opus** | Complex reasoning, analysis where imperfection compounds |
-| **Sonnet** | Validation, pattern matching, most agents |
-| **Haiku** | Mechanical execution, no judgment needed |
-</model-selection>
-
-<priorities>
-## Core Priorities
-
-1. User DX (plugin users)
-2. Worry-free automation
-3. Token efficiency
-4. Quality output
-5. Simplicity
-</priorities>
 
-<end-reminder>
-**REMEMBER**:
-- Use CHANGELOG.md for completion tracking (not summary files)
-- BEFORE starting → Read the relevant checklist (`checklists/*.md`)
-- BEFORE delivering any work, especially releases → Go through that checklist item by item
-- 3 platforms: Claude Code + OpenCode + Codex - ALL must work
-- Agent/Skill pattern: Agents invoke skills, skills have implementation
-- Create PRs for non-trivial changes
-</end-reminder>
+## References
 
-</project-memory>
+- Part of the [agentsys](https://github.com/agent-sh/agentsys) ecosystem
+- https://agentskills.io
diff --git a/bin/cli.js b/bin/cli.js
@@ -268,13 +268,6 @@ function resolvePluginDeps(names, marketplace) {
     }
     visiting.add(name);
 
-    const plugin = pluginMap[name];
-    if (plugin && plugin.requires) {
-      for (const dep of plugin.requires) {
-        visit(dep);
-      }
-    }
-
     visiting.delete(name);
     resolved.add(name);
   }
@@ -723,9 +716,7 @@ function satisfiesRange(ver, range) {
 }
 
 function checkCoreCompat(pluginEntry) {
-  if (pluginEntry.core && !satisfiesRange(VERSION, pluginEntry.core)) {
-    console.error(`[WARN] ${pluginEntry.name} requires agentsys ${pluginEntry.core}, you have ${VERSION}`);
-  }
+  // Core version compat check removed - field deprecated in schema
 }
 
 // --- Granular install helpers ---
@@ -1005,23 +996,13 @@ async function installPlugin(nameWithVersion, args) {
 // --- remove subcommand ---
 
 function removePlugin(name) {
-  const marketplace = loadMarketplace();
   const installed = loadInstalledJson();
 
   if (!installed.plugins[name]) {
     console.error(`[ERROR] Plugin ${name} is not installed.`);
     process.exit(1);
   }
 
-  // Check if any other installed plugin depends on this one
-  for (const [otherName] of Object.entries(installed.plugins)) {
-    if (otherName === name) continue;
-    const entry = marketplace.plugins.find(p => p.name === otherName);
-    if (entry && entry.requires && entry.requires.includes(name)) {
-      console.error(`[WARN] ${otherName} depends on ${name}. It may not work correctly after removal.`);
-    }
-  }
-
   const platforms = installed.plugins[name].platforms || [];
 
   // Remove from cache
diff --git a/lib/discovery/index.js b/lib/discovery/index.js
@@ -297,30 +297,6 @@ function getPluginPrefixRegex(repoRoot) {
   return new RegExp(`(${escaped.join('|')})`, 'g');
 }
 
-/**
- * Discover plugins from marketplace.json instead of scanning the filesystem.
- * Used in the post-extraction world where plugins/ no longer exists in agentsys.
- *
- * @param {string} [repoRoot] - Repository root path
- * @returns {Array<{name: string, source: string, version: string, requires: string[], core: string}>}
- */
-function discoverPluginsFromMarketplace(repoRoot) {
-  if (!repoRoot) {
-    repoRoot = path.resolve(__dirname, '..', '..');
-  }
-  const marketplacePath = path.join(repoRoot, '.claude-plugin', 'marketplace.json');
-  if (!fs.existsSync(marketplacePath)) return [];
-
-  const marketplace = JSON.parse(fs.readFileSync(marketplacePath, 'utf8'));
-  return (marketplace.plugins || []).map(p => ({
-    name: p.name,
-    source: p.source,
-    version: p.version,
-    requires: p.requires || [],
-    core: p.core || ''
-  }));
-}
-
 /**
  * Get all discovery results in a single call.
  *
@@ -365,7 +341,6 @@ module.exports = {
   parseFrontmatter,
   isValidPluginName,
   discoverPlugins,
-  discoverPluginsFromMarketplace,
   discoverCommands,
   discoverAgents,
   discoverSkills,
diff --git a/lib/schemas/plugin-manifest.schema.json b/lib/schemas/plugin-manifest.schema.json
