fix(rust): Make new methods consistent for all id params (#306)

Author: benbrandt

src/client.rs

@@ -329,12 +329,12 @@ pub struct RequestPermissionRequest {
 impl RequestPermissionRequest {
     #[must_use]
     pub fn new(
-        session_id: SessionId,
+        session_id: impl Into<SessionId>,
         tool_call: ToolCallUpdate,
         options: Vec<PermissionOption>,
     ) -> Self {
         Self {
-            session_id,
+            session_id: session_id.into(),
             tool_call,
             options,
             meta: None,
@@ -375,12 +375,12 @@ pub struct PermissionOption {
 
 impl PermissionOption {
     pub fn new(
-        option_id: PermissionOptionId,
+        option_id: impl Into<PermissionOptionId>,
         name: impl Into<String>,
         kind: PermissionOptionKind,
     ) -> Self {
         Self {
-            option_id,
+            option_id: option_id.into(),
             name: name.into(),
             kind,
             meta: None,
@@ -551,12 +551,12 @@ pub struct WriteTextFileRequest {
 
 impl WriteTextFileRequest {
     pub fn new(
-        session_id: SessionId,
+        session_id: impl Into<SessionId>,
         path: impl Into<PathBuf>,
         content: impl Into<String>,
     ) -> Self {
         Self {
-            session_id,
+            session_id: session_id.into(),
             path: path.into(),
             content: content.into(),
             meta: None,

src/rpc.rs

@@ -1,6 +1,6 @@
 use std::sync::Arc;
 
-use derive_more::Display;
+use derive_more::{Display, From};
 use schemars::JsonSchema;
 use serde::{Deserialize, Serialize, de::DeserializeOwned};
 use serde_json::value::RawValue;
@@ -20,13 +20,25 @@ use crate::{
 ///
 /// [2] Fractional parts may be problematic, since many decimal fractions cannot be represented exactly as binary fractions.
 #[derive(
-    Debug, PartialEq, Clone, Hash, Eq, Deserialize, Serialize, PartialOrd, Ord, Display, JsonSchema,
+    Debug,
+    PartialEq,
+    Clone,
+    Hash,
+    Eq,
+    Deserialize,
+    Serialize,
+    PartialOrd,
+    Ord,
+    Display,
+    JsonSchema,
+    From,
 )]
 #[serde(untagged)]
 #[allow(
     clippy::exhaustive_enums,
     reason = "This comes from the JSON-RPC specification itself"
 )]
+#[from(String, i64)]
 pub enum RequestId {
     #[display("null")]
     Null,
@@ -60,10 +72,16 @@ pub enum Response<Result> {
 }
 
 impl<R> Response<R> {
-    pub fn new(id: RequestId, result: Result<R>) -> Self {
+    pub fn new(id: impl Into<RequestId>, result: Result<R>) -> Self {
         match result {
-            Ok(result) => Self::Result { id, result },
-            Err(error) => Self::Error { id, error },
+            Ok(result) => Self::Result {
+                id: id.into(),
+                result,
+            },
+            Err(error) => Self::Error {
+                id: id.into(),
+                error,
+            },
         }
     }
 }