Setup lint config (#13)

* main repo

* rustc lints for all packages

* More lints

* adjust config

Author: benbrandt

Cargo.toml

@@ -62,3 +62,24 @@ jsonrpcmsg = "0.1.2"
 # Testing
 expect-test = "1.5"
 tokio-test = "0.4"
+
+[workspace.lints.rust]
+future_incompatible = { level = "warn", priority = -1 }
+let-underscore = "warn"
+missing_debug_implementations = "warn"
+# missing_docs = "warn"
+nonstandard_style = { level = "warn", priority = -1 }
+rust_2018_idioms = { level = "warn", priority = -1 }
+unused = { level = "warn", priority = -1 }
+
+[workspace.lints.clippy]
+# cargo = { level = "warn", priority = -1 }
+pedantic = { level = "warn", priority = -1 }
+doc_markdown = "allow"
+missing_errors_doc = "allow"
+missing_panics_doc = "allow"
+needless_pass_by_value = "allow"
+similar_names = "allow"
+struct_field_names = "allow"
+too_many_lines = "allow"
+wildcard_imports = "allow"

rust-toolchain.toml

@@ -45,3 +45,6 @@ tokio = { version = "1", features = [
     "sync",
 ] }
 tokio-util = { version = "0.7", features = ["compat"] }
+
+[lints]
+workspace = true

src/agent-client-protocol/Cargo.toml

@@ -26,6 +26,7 @@ pub use stream_broadcast::{
 /// prompts, and managing the agent lifecycle.
 ///
 /// See protocol docs: [Client](https://agentclientprotocol.com/protocol/overview#client)
+#[derive(Debug)]
 pub struct ClientSideConnection {
     conn: RpcConnection<ClientSide, AgentSide>,
 }
@@ -177,7 +178,7 @@ impl Agent for ClientSideConnection {
 /// are incoming vs outgoing from the client's perspective.
 ///
 /// See protocol docs: [Communication Model](https://agentclientprotocol.com/protocol/overview#communication-model)
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 pub struct ClientSide;
 
 impl Side for ClientSide {
@@ -316,6 +317,7 @@ impl<T: Client> MessageHandler<ClientSide> for T {
 /// and sending session updates.
 ///
 /// See protocol docs: [Agent](https://agentclientprotocol.com/protocol/overview#agent)
+#[derive(Debug)]
 pub struct AgentSideConnection {
     conn: RpcConnection<AgentSide, ClientSide>,
 }
@@ -482,7 +484,7 @@ impl Client for AgentSideConnection {
 /// are incoming vs outgoing from the agent's perspective.
 ///
 /// See protocol docs: [Communication Model](https://agentclientprotocol.com/protocol/overview#communication-model)
-#[derive(Clone)]
+#[derive(Clone, Debug)]
 pub struct AgentSide;
 
 impl Side for AgentSide {

src/agent-client-protocol/src/lib.rs

@@ -28,13 +28,15 @@ use serde_json::value::RawValue;
 
 use super::stream_broadcast::{StreamBroadcast, StreamReceiver, StreamSender};
 
+#[derive(Debug)]
 pub(crate) struct RpcConnection<Local: Side, Remote: Side> {
     outgoing_tx: UnboundedSender<OutgoingMessage<Local, Remote>>,
     pending_responses: Arc<Mutex<HashMap<RequestId, PendingResponse>>>,
     next_id: AtomicI64,
     broadcast: StreamBroadcast,
 }
 
+#[derive(Debug)]
 struct PendingResponse {
     deserialize: fn(&serde_json::value::RawValue) -> Result<Box<dyn Any + Send>>,
     respond: oneshot::Sender<Result<Box<dyn Any + Send>>>,
@@ -182,7 +184,7 @@ where
                     }
                     log::trace!("recv: {}", &incoming_line);
 
-                    match serde_json::from_str::<RawIncomingMessage>(&incoming_line) {
+                    match serde_json::from_str::<RawIncomingMessage<'_>>(&incoming_line) {
                         Ok(message) => {
                             if let Some(id) = message.id {
                                 if let Some(method) = message.method {
@@ -299,7 +301,7 @@ where
     }
 }
 
-#[derive(Deserialize)]
+#[derive(Debug, Deserialize)]
 pub struct RawIncomingMessage<'a> {
     id: Option<RequestId>,
     method: Option<&'a str>,
@@ -308,6 +310,7 @@ pub struct RawIncomingMessage<'a> {
     error: Option<Error>,
 }
 
+#[derive(Debug)]
 pub enum IncomingMessage<Local: Side> {
     Request {
         id: RequestId,

src/agent-client-protocol/src/rpc.rs

@@ -36,3 +36,6 @@ sacp-tokio = { version = "1.0.0", path = "../sacp-tokio" }
 
 [dev-dependencies]
 expect-test.workspace = true
+
+[lints]
+workspace = true

src/elizacp/Cargo.toml

@@ -20,6 +20,7 @@ struct Pattern {
 }
 
 /// The Eliza chatbot engine.
+#[derive(Debug)]
 pub struct Eliza {
     patterns: Vec<Pattern>,
     reflections: HashMap<String, String>,
@@ -29,11 +30,13 @@ pub struct Eliza {
 impl Eliza {
     /// Create a new Eliza instance with classic patterns.
     /// Uses a fixed seed for deterministic testing.
+    #[must_use]
     pub fn new() -> Self {
         Self::with_seed(42)
     }
 
     /// Create a new Eliza instance with a specific seed.
+    #[must_use]
     pub fn with_seed(seed: u64) -> Self {
         let mut eliza = Self {
             patterns: Vec::new(),
@@ -210,7 +213,10 @@ impl Eliza {
         let regex = Regex::new(pattern).expect("Invalid regex pattern");
         self.patterns.push(Pattern {
             pattern: regex,
-            responses: responses.into_iter().map(|s| s.to_string()).collect(),
+            responses: responses
+                .into_iter()
+                .map(std::string::ToString::to_string)
+                .collect(),
             priority,
         });
     }
@@ -225,7 +231,7 @@ impl Eliza {
                 self.reflections
                     .get(&lower)
                     .cloned()
-                    .unwrap_or_else(|| word.to_string())
+                    .unwrap_or_else(|| (*word).to_string())
             })
             .collect();
         reflected.join(" ")
@@ -291,10 +297,10 @@ mod tests {
         let eliza = Eliza::new();
 
         let reflected = eliza.reflect("I am happy");
-        expect![[r#"you are happy"#]].assert_eq(&reflected);
+        expect![[r"you are happy"]].assert_eq(&reflected);
 
         let reflected = eliza.reflect("my mother");
-        expect![[r#"your mother"#]].assert_eq(&reflected);
+        expect![[r"your mother"]].assert_eq(&reflected);
     }
 
     #[test]
@@ -334,8 +340,7 @@ mod tests {
             let response2 = eliza2.respond(input);
             assert_eq!(
                 response1, response2,
-                "Responses should be identical for input: {}",
-                input
+                "Responses should be identical for input: {input}"
             );
         }
 

src/elizacp/src/eliza.rs

@@ -43,7 +43,7 @@ impl ElizaAgent {
         tracing::info!("Ended session: {}", session_id);
     }
 
-    async fn handle_new_session(
+    fn handle_new_session(
         &self,
         request: NewSessionRequest,
         request_cx: sacp::JrRequestCx<NewSessionResponse>,
@@ -65,7 +65,7 @@ impl ElizaAgent {
         request_cx.respond(response)
     }
 
-    async fn handle_load_session(
+    fn handle_load_session(
         &self,
         request: LoadSessionRequest,
         request_cx: sacp::JrRequestCx<LoadSessionResponse>,
@@ -85,7 +85,7 @@ impl ElizaAgent {
         request_cx.respond(response)
     }
 
-    async fn handle_prompt_request(
+    fn handle_prompt_request(
         &self,
         request: PromptRequest,
         request_cx: sacp::JrRequestCx<PromptResponse>,
@@ -105,10 +105,7 @@ impl ElizaAgent {
         let response_text = self
             .get_response(session_id, &input_text)
             .unwrap_or_else(|| {
-                format!(
-                    "Error: Session {} not found. Please start a new session.",
-                    session_id
-                )
+                format!("Error: Session {session_id} not found. Please start a new session.")
             });
 
         tracing::debug!("Eliza response: {}", response_text);
@@ -159,34 +156,29 @@ pub async fn run_elizacp(transport: impl Component + 'static) -> Result<(), sacp
 
                 request_cx.respond(InitializeResponse {
                     protocol_version: initialize.protocol_version,
-                    agent_capabilities: AgentCapabilities {
-                        load_session: Default::default(),
-                        prompt_capabilities: Default::default(),
-                        mcp_capabilities: Default::default(),
-                        meta: Default::default(),
-                    },
-                    auth_methods: Default::default(),
-                    agent_info: Default::default(),
-                    meta: Default::default(),
+                    agent_capabilities: AgentCapabilities::default(),
+                    auth_methods: Vec::default(),
+                    agent_info: Option::default(),
+                    meta: None,
                 })
             }
         })
         .on_receive_request({
             let agent = agent.clone();
             async move |request: NewSessionRequest, request_cx| {
-                agent.handle_new_session(request, request_cx).await
+                agent.handle_new_session(request, request_cx)
             }
         })
         .on_receive_request({
             let agent = agent.clone();
             async move |request: LoadSessionRequest, request_cx| {
-                agent.handle_load_session(request, request_cx).await
+                agent.handle_load_session(request, request_cx)
             }
         })
         .on_receive_request({
             let agent = agent.clone();
             async move |request: PromptRequest, request_cx| {
-                agent.handle_prompt_request(request, request_cx).await
+                agent.handle_prompt_request(request, request_cx)
             }
         })
         .connect_to(transport)?

src/elizacp/src/lib.rs

@@ -41,3 +41,6 @@ schemars.workspace = true
 sacp-rmcp = { path = "../sacp-rmcp" }
 sacp-test = { path = "../sacp-test" }
 sacp-tokio = { path = "../sacp-tokio" }
+
+[lints]
+workspace = true