Skip to content

Commit 014d0b9

Browse files
authored
Merge pull request #9 from nikomatsakis/main
refactor the crate names, 1.0-alpha
2 parents 2148ae1 + 65c1766 commit 014d0b9

37 files changed

+195
-135
lines changed

Cargo.lock

Lines changed: 12 additions & 12 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

release-plz.toml

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
# Release-plz configuration for symposium-acp workspace
2+
# See: https://release-plz.dev/docs/config
3+
4+
[workspace]
5+
# Safer release strategy - only release when merging the release PR
6+
# (avoids race conditions with squash-merge)
7+
release_always = false
8+
9+
# Keep dependencies updated in Cargo.lock
10+
dependencies_update = true
11+
12+
# Tag release PRs for visibility
13+
pr_labels = ["release"]
14+
15+
# Package-specific configurations
16+
[[package]]
17+
name = "sacp-doc-test"
18+
# Don't publish documentation test package to crates.io
19+
publish = false

src/elizacp/Cargo.toml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "elizacp"
3-
version = "0.1.0"
3+
version = "1.0.0-alpha"
44
edition = "2024"
55
description = "Classic Eliza chatbot as an ACP agent for testing"
66
license = "MIT OR Apache-2.0"
@@ -15,7 +15,7 @@ name = "elizacp"
1515
path = "src/main.rs"
1616

1717
[dependencies]
18-
sacp = { version = "0.2.0", path = "../sacp" }
18+
sacp = { version = "1.0.0-alpha", path = "../sacp" }
1919
agent-client-protocol-schema.workspace = true
2020
anyhow.workspace = true
2121
clap.workspace = true

src/elizacp/src/main.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ mod eliza;
3939
use anyhow::Result;
4040
use clap::Parser;
4141
use eliza::Eliza;
42-
use sacp::{
42+
use sacp::JrConnection;
43+
use sacp::schema::{
4344
AgentCapabilities, ContentBlock, ContentChunk, InitializeRequest, InitializeResponse,
44-
JrConnection, LoadSessionRequest, LoadSessionResponse, NewSessionRequest, NewSessionResponse,
45-
PromptRequest, PromptResponse, SessionId, SessionNotification, SessionUpdate, StopReason,
46-
TextContent,
45+
LoadSessionRequest, LoadSessionResponse, NewSessionRequest, NewSessionResponse, PromptRequest,
46+
PromptResponse, SessionId, SessionNotification, SessionUpdate, StopReason, TextContent,
4747
};
4848
use std::collections::HashMap;
4949
use std::sync::{Arc, Mutex};

src/sacp-conductor/Cargo.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "sacp-conductor"
3-
version = "0.2.0"
3+
version = "1.0.0-alpha"
44
edition = "2024"
55
description = "Conductor for orchestrating SACP proxy chains"
66
license = "MIT OR Apache-2.0"
@@ -12,8 +12,8 @@ categories = ["development-tools"]
1212
test-support = []
1313

1414
[dependencies]
15-
sacp = { version = "0.2.0", path = "../sacp" }
16-
sacp-proxy = { version = "0.1.2", path = "../sacp-proxy" }
15+
sacp = { version = "1.0.0-alpha", path = "../sacp" }
16+
sacp-proxy = { version = "1.0.0-alpha", path = "../sacp-proxy" }
1717
agent-client-protocol-schema.workspace = true
1818
anyhow.workspace = true
1919
clap.workspace = true

src/sacp-conductor/src/component.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ use sacp::JrConnectionCx;
88
use tokio::process::Child;
99
use tracing::debug;
1010

11-
/// "Provider" used to spawn components. The [`CommandProvider`] is used from the CLI, but for testing
12-
/// or internal purposes, other comment providers may be created.
11+
/// "Provider" used to spawn components. The `CommandProvider` is used from the CLI, but for testing
12+
/// or internal purposes, other component providers may be created.
1313
pub trait ComponentProvider: Send {
1414
/// Create a component that will read/write ACP messages from the given streams.
1515
/// The `cx` can be used to spawn tasks running in the JSON RPC connection.

src/sacp-conductor/src/conductor.rs

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,15 +63,16 @@
6363
use std::{collections::HashMap, pin::Pin};
6464

6565
use futures::{AsyncRead, AsyncWrite, SinkExt, StreamExt, channel::mpsc};
66-
use sacp::{InitializeRequest, InitializeResponse, NewSessionRequest, NewSessionResponse};
66+
use sacp::schema::{InitializeRequest, InitializeResponse, NewSessionRequest, NewSessionResponse};
6767
use sacp_proxy::{
6868
McpConnectRequest, McpConnectResponse, McpDisconnectNotification, McpOverAcpNotification,
6969
McpOverAcpRequest, SuccessorNotification, SuccessorRequest,
7070
};
7171

72+
use sacp::handler::NullHandler;
7273
use sacp::{
7374
JrConnection, JrConnectionCx, JrNotification, JrRequest, JrRequestCx, JrResponse, MessageAndCx,
74-
MetaCapabilityExt, NullHandler, Proxy, UntypedMessage,
75+
MetaCapabilityExt, Proxy, UntypedMessage,
7576
util::{TypeNotification, TypeRequest},
7677
};
7778
use tokio_util::compat::{TokioAsyncReadCompatExt, TokioAsyncWriteCompatExt};
@@ -732,7 +733,7 @@ impl Conductor {
732733
async fn forward_session_new_request(
733734
&mut self,
734735
target_component_index: usize,
735-
mut request: sacp::NewSessionRequest,
736+
mut request: NewSessionRequest,
736737
conductor_tx: &mpsc::Sender<ConductorMessage>,
737738
request_cx: JrRequestCx<NewSessionResponse>,
738739
) -> Result<(), sacp::Error> {

src/sacp-conductor/src/conductor/mcp_bridge.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ use std::{collections::HashMap, net::SocketAddr};
22

33
use futures::{SinkExt, StreamExt as _, channel::mpsc};
44
use sacp;
5-
use sacp::McpServer;
5+
use sacp::schema::McpServer;
66
use sacp::{JrConnection, JrConnectionCx, MessageAndCx};
77
use sacp_proxy::McpDisconnectNotification;
88
use tokio::net::TcpStream;
@@ -51,7 +51,7 @@ impl McpBridgeListeners {
5151
conductor_tx: &mpsc::Sender<ConductorMessage>,
5252
conductor_command: &[String],
5353
) -> Result<(), sacp::Error> {
54-
use sacp::McpServer;
54+
use sacp::schema::McpServer;
5555

5656
let McpServer::Http { name, url, headers } = mcp_server else {
5757
return Ok(());

src/sacp-conductor/tests/initialization_sequence.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,7 @@
77
//! 4. Last component (agent) never receives proxy capability offer
88
99
use futures::{AsyncRead, AsyncWrite};
10-
use sacp::AgentCapabilities;
11-
use sacp::{InitializeRequest, InitializeResponse};
10+
use sacp::schema::{AgentCapabilities, InitializeRequest, InitializeResponse};
1211
use sacp::{JrConnection, JrConnectionCx, MetaCapabilityExt, Proxy};
1312
use sacp_conductor::component::{Cleanup, ComponentProvider};
1413
use sacp_conductor::conductor::Conductor;

src/sacp-conductor/tests/mcp-integration.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ mod mcp_integration;
1010
use expect_test::expect;
1111
use futures::{SinkExt, StreamExt, channel::mpsc};
1212
use sacp::JrConnection;
13-
use sacp::{
13+
use sacp::schema::{
1414
ContentBlock, InitializeRequest, NewSessionRequest, PromptRequest, SessionNotification,
1515
TextContent,
1616
};

0 commit comments

Comments
 (0)