Skip to content

Commit 4c07a8c

Browse files
committed
* extract if statement to the outside of the activate_data_module func.
1 parent 75c7c8b commit 4c07a8c

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

trinity/cli/launcher.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,18 @@ def both(config: Config) -> None:
9595
logger.info("Eval step finished.")
9696

9797

98-
def activate_data_module(config: Config, config_path: str):
98+
def activate_data_module(config_path: str):
9999
"""Check whether to activate data module and preprocess datasets."""
100-
data_config = config.data
101-
if data_config.dj_config_path or data_config.dj_process_desc:
102-
from trinity.data.client import LOCAL_SERVER_URL, request
100+
from trinity.data.client import LOCAL_SERVER_URL, request
103101

104-
logger.info("Activating data module...")
105-
res = request(
106-
url=LOCAL_SERVER_URL,
107-
configPath=config_path,
108-
)
109-
if res["return_code"] != 0:
110-
logger.error(f"Failed to activate data module: {res['return_msg']}.")
111-
return
102+
logger.info("Activating data module...")
103+
res = request(
104+
url=LOCAL_SERVER_URL,
105+
configPath=config_path,
106+
)
107+
if res["return_code"] != 0:
108+
logger.error(f"Failed to activate data module: {res['return_msg']}.")
109+
return
112110

113111

114112
def main() -> None:
@@ -128,7 +126,9 @@ def main() -> None:
128126
config = load_config(args.config)
129127
config.check_and_update()
130128
# try to activate data module
131-
activate_data_module(config, args.config)
129+
data_config = config.data
130+
if data_config.dj_config_path or data_config.dj_process_desc:
131+
activate_data_module(args.config)
132132
ray.init()
133133
if config.mode == "explore":
134134
explore(config)

0 commit comments

Comments
 (0)