Skip to content

Commit aaa6aae

Browse files
committed
apply suggestions from gemini
1 parent 70ccf4d commit aaa6aae

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

trinity/common/config.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -931,6 +931,8 @@ def _check_explorer_input(self) -> None:
931931
dataset.batch_size = self.buffer.batch_size
932932
if not dataset.name:
933933
dataset.name = f"eval_taskset_{idx}"
934+
if len(dataset.eval_at_k) == 0:
935+
dataset.eval_at_k = [1]
934936
dataset.repeat_times = max(dataset.eval_at_k)
935937

936938
# eval_workflow has higher priority than workflow in eval tasksets, so we set it first

trinity/explorer/scheduler.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,8 @@ def calculate_task_level_metrics(
5858
if k > len(values):
5959
continue
6060
result[f"{key}/mean@{k}"] = sum(values[:k]) / k
61-
result[f"{key}/best@{k}"] = max(values[:k]) / k
62-
result[f"{key}/worst@{k}"] = min(values[:k]) / k
61+
result[f"{key}/best@{k}"] = max(values[:k])
62+
result[f"{key}/worst@{k}"] = min(values[:k])
6363
return result
6464
else:
6565
return {

0 commit comments

Comments
 (0)