Merged
Conversation
…ted). 2. Support GLM VL series. 3. Bug fix in `dp_actor.py`. 4. Fix in `explorer` when `trainer` early exit. 5. Bug fix for kimi vl when using ulysses sequence parallel. 6. Replace `print` with `logger.info` in `fsdp_workers.py`
Collaborator
Author
|
/gemini review |
Contributor
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly updates the system's compatibility with the latest Hugging Face Transformers library (v5) and expands support for advanced Vision-Language models, particularly the GLM series. It also includes critical bug fixes for training stability and multimodal processing, alongside refactoring efforts to improve code structure and maintainability. The changes aim to enhance the platform's ability to train and deploy state-of-the-art large language models, especially those with multimodal capabilities. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Transformers v5 and GLM VL series models. It includes substantial monkey-patching for vLLM to ensure compatibility, along with several bug fixes and refactorings. Key changes include updating model detection logic, moving trainer-related modules into their own subdirectories, fixing an indentation bug in dp_actor.py, and improving robustness in explorer.py by adding None checks. Additionally, many print statements have been replaced with logger.info for better logging practices. The changes are well-structured and address the goals outlined in the description. I have one suggestion to improve the maintainability of the vLLM patch.
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Transformers v5 and GLM VL models, involving significant patching for compatibility with vLLM and internal components. The changes also include refactoring of the trainer modules, bug fixes for data processing and explorer stability, and improvements in logging. Overall, the changes are well-structured and address the stated goals. I've found one issue in a vLLM patch that needs to be addressed.
Collaborator
Author
|
/unittest-all |
Summary
Failed Tests
Skipped
Tests
Github Test Reporter by CTRF 💚 |
Collaborator
Author
|
/unittest-pattern-TestTrainerCountdown_1_megatron |
Summary
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
reviewed
Feb 28, 2026
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-all |
Collaborator
Author
|
/unittest-all |
Summary
Skipped
Tests
Github Test Reporter by CTRF 💚 |
pan-x-c
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
dp_actor.py.explorerwhentrainerearly exit.printwithlogger.infoinfsdp_workers.pyChecklist
Please check the following items before code is ready to be reviewed.