You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Correct YAML support framing: Full support, not optional
🎯 Framing Correction:
- Changed 'Optional YAML support' to 'Full YAML marshal/unmarshal support'
- Removed YAML from 'Optional Advanced Features' section
- Updated comparison table: 'Optional (with go-yaml)' → 'Full YAML marshal/unmarshal'
- Enhanced serialization descriptions to include YAML as core feature
💡 Technical Accuracy:
- UTC package implements MarshalYAML/UnmarshalYAML methods in main package
- This follows standard Go pattern (same as JSON - requires external library)
- Not 'optional' - it's full YAML support using Go's interface system
- Works with any YAML library that implements Go's standard interfaces
📝 Updated Language:
- 'Optional dependencies' → 'YAML Usage' with installation instructions
- Removed 'testing-focused' language about YAML
- Emphasized full YAML support comparable to JSON support
- Clarified that external YAML library is standard Go pattern
✅ Consistent Positioning:
- YAML now positioned as core serialization feature alongside JSON
- Maintains technical honesty while proper feature representation
- Aligns with how Go ecosystem typically handles serialization libraries
This better represents the package's true capabilities - full YAML support
that works with standard Go YAML libraries, not a limited optional feature.
// YAML marshaling (requires a YAML library like go-yaml)
207
208
type Config struct {
208
209
StartTime utc.Time `yaml:"start_time"`
209
210
EndTime utc.Time `yaml:"end_time"`
@@ -218,7 +219,7 @@ type Record struct {
218
219
219
220
## YAML Support
220
221
221
-
The package includes YAML marshaling/unmarshaling methods (`MarshalYAML`/`UnmarshalYAML`) that implement the standard YAML interfaces. However, **YAML support is primarily used for testing** and requires an external dependency.
222
+
The package includes full YAML marshaling/unmarshaling support through `MarshalYAML`/`UnmarshalYAML` methods that implement the standard YAML interfaces. Works with any Go YAML library that follows these interfaces.
222
223
223
224
**Requirements for YAML testing**:
224
225
- Go 1.21.0+ (required by go-yaml dependency)
@@ -314,7 +315,7 @@ Key features:
314
315
315
316
- All times are automatically converted to and stored in UTC
316
317
- JSON marshaling/unmarshaling with flexible parsing
0 commit comments