refactor: improve upgrade script for cross-platform compatibility and sequential upgrades (#238)

* refactor: upgrade script

* chore: nit

* chore: nits

* chore: nits

* chore: nit

* refactor: pos upgrade scenario (#240)

* chore: filter l2-el and l2-cl containers

* chore: rename method and add check on containers

* chore: nit

* chore: nit

* chore: nit

* chore: rename methods

* chore: reduce requests made to the CL node

* chore: add liveness check to get_any_cl_api_url

* chore: nit

* chore: define local vars

* chore: clean up

* chore: clean up

* chore: clean up upgrade_cl_node

* chore: clean up upgrade_el_node

* chore: clean up

* chore: add docker_network_name var

* chore: add sections

* chore: nit

* docs: update comments

* chore: clean up

* chore: clean up

* chore: wait_for_devnet_to_reach_block

* chore: nit

* chore: clean up

* fix: typo

* fix: shellcheck issues

* fix: same

* chore: nit

* chore: use amd64 images by default

* chore: same

* fix: sleep interval

* fix: typo

* chore: nit

* chore: nit

* chore: nit

* chore: update logs

* chore: nit

* chore: nit

* chore: nit

* fix: typo

* chore: nit

* docs: remove nodes from comments

* chore: nit

* docs: document script and wait for network to progress

* fix: use docker instead of kurtosis to wait for rpcs to reach block

* chore: remove loop

* fix: typo

* chore: update output.log

* chore: nit

* fix: nits

* chore: fix readme

* fix: typo

* docs: nit

* update README

* fix: get_orphaned_containers

* chore: nit

* doc: add sleep 1 comment

---------

Co-authored-by: kamuikatsurgi <shahkrishang11@gmail.com>

---------

Co-authored-by: Léo Vincent <28714795+leovct@users.noreply.github.com>

Author: kamuikatsurgi

scenarios/pos/upgrade/.env.example

@@ -1,6 +1,7 @@
 ENCLAVE_NAME=pos
-KURTOSIS_POS_VERSION=v1.2.11
+KURTOSIS_POS_VERSION=v1.2.12
+RIO_FORK_BLOCK=256
 
-NEW_BOR_IMAGE=0xpolygon/bor:2.6.0-beta
-NEW_ERIGON_IMAGE=0xpolygon/erigon:v3.4.0-beta
+NEW_BOR_IMAGE=0xpolygon/bor:2.6.0-amd64
+NEW_ERIGON_IMAGE=0xpolygon/erigon:v3.4.0
 NEW_HEIMDALL_V2_IMAGE=0xpolygon/heimdall-v2:0.6.0

scenarios/pos/upgrade/README.md

@@ -1,18 +1,35 @@
 # PoS Upgrade Scenario
+
 Test a rolling upgrade of [kurtosis-pos](https://github.com/0xPolygon/kurtosis-pos) devnet nodes. Non-block-producing nodes are upgraded first, then block producers last to maintain network stability.
 
 ## Usage
 
 1. Copy `.env.example` to `.env` and configure:
    - `ENCLAVE_NAME`: Name of the Kurtosis enclave
-   - `KURTOSIS_POS_VERSION`: Initial kurtosis-pos package version
+   - `KURTOSIS_POS_VERSION`: Initial kurtosis-pos package version (branch, tag, or commit)
+   - `RIO_FORK_BLOCK` (optional): Block number for Rio hard fork activation (default: `256`)
    - `NEW_BOR_IMAGE`: Target Bor client image
-   - `NEW_HEIMDALL_IMAGE`: Target Heimdall client image
+   - `NEW_HEIMDALL_V2_IMAGE`: Target Heimdall v2 client image
    - `NEW_ERIGON_IMAGE`: Target Erigon client image
 
+   ```bash
+   cp .env.example .env
+   ```
+
 2. (Optional) Customize `params.yml` for devnet configuration.
 
 3. Run the scenario:
+
    ```bash
-   sudo ./run.sh
+   bash run.sh
    ```
+
+## Cleanup
+
+Remove the enclave, orphaned containers, and temporary data before re-running:
+
+```bash
+kurtosis enclave rm --force pos
+docker ps --all --format '{{.Names}}' | grep -E '^l2-(e|c)l-.*-.*-' | xargs docker rm --force
+rm -rf ./tmp
+```