[Feature Request] Mute when text is empty

[Caspal83]

With Deezer application (dezzer.android.app), when ad is played, we see that Title, Text and SubText are empty (verified with debug log).
When configuring custom app, Keywords is mandatory. We cannot select anything for the case described here.
Deezer is a widely used app, it would be cool to use ad-silence with it.

[aghontpi]

Hi @Caspal83 , thanks for the request, I tried it on my phone, looks like its region locked, I will try it on a emulator while making the change.

in the mean time, can u share a screenshot of the deezer app's notification alone while ad is playing.

[Caspal83]

Hello @aghontpi ,
Thanks for your reply
You'll find 3 screenshot in attachment

• Deezer playing music

• Deezer playing ad
  
• Ad-silence log

Hope this helps

[aghontpi]

this helps, when I tried emulator yesterday, for a video ad I couldn't replicate this,

but today.. while testing I got the same what you were reporting.. thanks will update here on the changes.

[aghontpi]

Its implemented here, #326, you need to put "allow-keyword-empty" without quotes in the keyword field. you can use the dev build from the pull request #326 (comment)

I've tested it for sometime, it does work with empty notifications.

I chose this implementation over others so users accidentally dont keep the field as emtpy causing issues.. and anyone who wants empty keywords can explicitly mention and use it.

this will be part of next release, #327 until then you can use the debug build I've shared above.

edit:

will mark this as complete and close once all the pr tasks are done and merged to next release branch.

[aghontpi]

this is how it should look.