Skipping range checks on nullable to non-nullable, same numeric type mappings

Author: SteveWilkes

AgileMapper.UnitTests/WhenViewingMappingPlans.cs

@@ -249,6 +249,14 @@ public void ShouldNotDuplicateChildMappingPlans()
             numberOfObjectToProductPlans.ShouldBe(1);
         }
 
+        [Fact]
+        public void ShouldNotRangeCheckNullableToNonNullableValues()
+        {
+            var plan = Mapper.GetPlanFor<PublicField<int?>>().ToANew<PublicField<int>>();
+
+            plan.ShouldNotContain("int.MinValue");
+        }
+
         [Fact]
         public void ShouldShowEnumMismatches()
         {

AgileMapper/TypeConversion/NumericValueIsInRangeComparison.cs

@@ -8,21 +8,19 @@ internal static class NumericValueIsInRangeComparison
     {
         public static Expression For(Expression sourceValue, Type nonNullableTargetType)
         {
-            Expression maxValueComparisonLeftSide, maxValueComparisonRightSide;
             GetMaximumValueComparisonOperands(
                 sourceValue,
                 sourceValue.Type,
                 nonNullableTargetType,
-                out maxValueComparisonLeftSide,
-                out maxValueComparisonRightSide);
+                out Expression maxValueComparisonLeftSide,
+                out Expression maxValueComparisonRightSide);
 
-            Expression minValueComparisonLeftSide, minValueComparisonRightSide;
             GetMinimumValueComparisonOperands(
                 sourceValue,
                 sourceValue.Type,
                 nonNullableTargetType,
-                out minValueComparisonLeftSide,
-                out minValueComparisonRightSide);
+                out Expression minValueComparisonLeftSide,
+                out Expression minValueComparisonRightSide);
 
             var sourceValueIsLessThanOrEqualToMaxValue =
                 Expression.LessThanOrEqual(maxValueComparisonLeftSide, maxValueComparisonRightSide);

AgileMapper/TypeConversion/ToNumericConverterBase.cs

@@ -61,8 +61,14 @@ private static bool IsNonNumericType(Type type)
 
         private static Expression GetCheckedNumericConversion(Expression sourceValue, Type targetType)
         {
-            var numericValueIsValid = GetNumericValueValidityCheck(sourceValue, targetType);
             var castSourceValue = sourceValue.GetConversionTo(targetType);
+
+            if (sourceValue.Type.GetNonNullableType() == targetType.GetNonNullableType())
+            {
+                return castSourceValue;
+            }
+
+            var numericValueIsValid = GetNumericValueValidityCheck(sourceValue, targetType);
             var defaultTargetType = targetType.ToDefaultExpression();
             var inRangeValueOrDefault = Expression.Condition(numericValueIsValid, castSourceValue, defaultTargetType);