Skipping definition of enumerable mapping loop continue label where possible

Author: SteveWilkes

AgileMapper/ObjectPopulation/Enumerables/Dictionaries/DictionaryPopulationBuilder.cs

@@ -89,6 +89,8 @@ private Expression AssignDictionaryEntryFromKeyValuePair(
 
         private Expression AssignDictionaryEntry(IPopulationLoopData loopData, IObjectMappingData mappingData)
         {
+            loopData.NeedsContinueTarget = true;
+
             var dictionaryEntryMember = _targetDictionaryMember.GetElementMember();
 
             return AssignDictionaryEntry(loopData, dictionaryEntryMember, mappingData);

AgileMapper/ObjectPopulation/Enumerables/EnumerableSourcePopulationLoopData.cs

@@ -39,6 +39,8 @@ public EnumerableSourcePopulationLoopData(
 
         public EnumerablePopulationBuilder Builder { get; }
 
+        public bool NeedsContinueTarget { get; set; }
+
         public LabelTarget ContinueLoopTarget { get; }
 
         public Expression LoopExitCheck { get; }

AgileMapper/ObjectPopulation/Enumerables/IPopulationLoopData.cs

@@ -6,6 +6,8 @@
 
     internal interface IPopulationLoopData
     {
+        bool NeedsContinueTarget { get; set; }
+
         LabelTarget ContinueLoopTarget { get; }
 
         Expression LoopExitCheck { get; }
@@ -36,7 +38,10 @@ public static Expression BuildPopulationLoop<TLoopData>(
                 elementPopulation,
                 Expression.PreIncrementAssign(builder.Counter));
 
-            var populationLoop = Expression.Loop(loopBody, breakLoop.Target, loopData.ContinueLoopTarget);
+            var populationLoop = loopData.NeedsContinueTarget
+                ? Expression.Loop(loopBody, breakLoop.Target, loopData.ContinueLoopTarget)
+                : Expression.Loop(loopBody, breakLoop.Target);
+
             var adaptedLoop = loopData.Adapt(populationLoop);
 
             var population = Expression.Block(

AgileMapper/ObjectPopulation/Enumerables/IndexedSourcePopulationLoopData.cs

@@ -28,6 +28,8 @@ public IndexedSourcePopulationLoopData(EnumerablePopulationBuilder builder)
                 : builder.Context.GetSourceParameterFor(builder.SourceTypeHelper.ElementType);
         }
 
+        public bool NeedsContinueTarget { get; set; }
+
         public LabelTarget ContinueLoopTarget { get; }
 
         public Expression LoopExitCheck { get; }

AgileMapper/ObjectPopulation/Enumerables/SourceElementsDictionaryPopulationLoopData.cs

@@ -113,6 +113,8 @@ private Expression GetContainsElementKeyCheck()
         private Expression GetNoKeysWithMatchingStartQuery()
             => _dictionaryVariables.GetNoKeysWithMatchingStartQuery(_targetElementKey);
 
+        public bool NeedsContinueTarget { get; set; }
+
         public LabelTarget ContinueLoopTarget { get; }
 
         public Expression LoopExitCheck { get; }

AgileMapper/ObjectPopulation/Enumerables/SourceObjectDictionaryPopulationLoopData.cs

@@ -1,6 +1,5 @@
 namespace AgileObjects.AgileMapper.ObjectPopulation.Enumerables
 {
-    using System.Linq;
     using System.Linq.Expressions;
     using DataSources;
     using Extensions;
@@ -41,6 +40,8 @@ private Expression GetCompositeLoopExitCheck()
             return Expression.Block(ifEnumeratorReturnResult, returnElementsResult);
         }
 
+        public bool NeedsContinueTarget { get; set; }
+
         public LabelTarget ContinueLoopTarget { get; }
 
         public Expression LoopExitCheck { get; }