Splitting parameter lists with more than 3 parameters onto multiple lines

Author: SteveWilkes

ReadableExpressions.UnitTests/WhenFormattingCode.cs

@@ -17,9 +17,9 @@ public void ShouldSplitLongConstructorArgumentListsOntoMultipleLines()
             var helperConstructor = helperVariable.Type.GetConstructors().First();
             var longVariable = Expression.Variable(typeof(int), "thisVariableReallyHasAVeryLongNameIndeed");
             var newHelper = Expression.New(helperConstructor, longVariable, longVariable, longVariable);
-            var assignHelper = Expression.Assign(helperVariable, newHelper);
+            var helperAssignment = Expression.Assign(helperVariable, newHelper);
 
-            var longArgumentListBlock = Expression.Block(new[] { helperVariable }, assignHelper);
+            var longArgumentListBlock = Expression.Block(new[] { helperVariable }, helperAssignment);
 
             var translated = longArgumentListBlock.ToReadableString();
 
@@ -32,6 +32,35 @@ public void ShouldSplitLongConstructorArgumentListsOntoMultipleLines()
             Assert.AreEqual(EXPECTED.TrimStart(), translated);
         }
 
+        [TestMethod]
+        public void ShouldSplitMultipleArgumentListsOntoMultipleLines()
+        {
+            var intsMethod = typeof(HelperClass)
+                .GetMethod("GiveMeFourInts", BindingFlags.Public | BindingFlags.Instance);
+
+            var helperVariable = Expression.Variable(typeof(HelperClass), "helper");
+            var intVariable = Expression.Variable(typeof(int), "intVariable");
+
+            var intsMethodCall = Expression.Call(
+                helperVariable,
+                intsMethod,
+                intVariable,
+                intVariable,
+                intVariable,
+                intVariable);
+
+            var translated = intsMethodCall.ToReadableString();
+
+            const string EXPECTED = @"
+helper.GiveMeFourInts(
+    intVariable,
+    intVariable,
+    intVariable,
+    intVariable)";
+
+            Assert.AreEqual(EXPECTED.TrimStart(), translated);
+        }
+
         [TestMethod]
         public void ShouldSplitLongArgumentListsOntoMultipleLines()
         {
@@ -542,6 +571,10 @@ public HelperClass(int intOne, int intTwo, int intThree)
         public void GiveMeSomeInts(int intOne, int intTwo, int intThree)
         {
         }
+
+        public void GiveMeFourInts(int intOne, int intTwo, int intThree, int intFour)
+        {
+        }
     }
     // ReSharper restore UnusedParameter.Local
 

ReadableExpressions/Translators/Formatting/FormattableExpressionBase.cs

@@ -17,11 +17,16 @@ protected string GetFormattedTranslation()
         {
             var translation = SingleLineTranslationFactory.Invoke();
 
-            return (translation.Length > 100) || translation.IsMultiLine()
+            return SplitToMultipleLines(translation)
                 ? MultipleLineTranslationFactory.Invoke()
                 : translation;
         }
 
+        protected virtual bool SplitToMultipleLines(string translation)
+        {
+            return (translation.Length > 100) || translation.IsMultiLine();
+        }
+
         public override string ToString()
         {
             return GetFormattedTranslation();

ReadableExpressions/Translators/Formatting/ParameterSet.cs

@@ -186,6 +186,11 @@ private Func<Expression, string> MethodGroupTranslator
             }
         }
 
+        protected override bool SplitToMultipleLines(string translation)
+        {
+            return (_arguments.Count() > 3) || base.SplitToMultipleLines(translation);
+        }
+
         protected override Func<string> SingleLineTranslationFactory => () => FormatParameters(", ");
 
         protected override Func<string> MultipleLineTranslationFactory