Adding parentheses around equality test condition operands - re: issue #22

Author: SteveWilkes

ReadableExpressions.UnitTests/WhenTranslatingConditionals.cs

@@ -483,6 +483,22 @@ public void ShouldTranslateAssignmentOutcomeTests()
 
             translated.ShouldBe(EXPECTED.TrimStart());
         }
+
+        // See https://github.com/agileobjects/ReadableExpressions/issues/22
+        [Fact]
+        public void ShouldTranslateEnumComparisonTests()
+        {
+            var flagParameter = Expression.Parameter(typeof(bool), "flag");
+            var one = Expression.Constant(Test.One);
+            var two = Expression.Constant(Test.Two);
+            var oneOrTwo = Expression.Condition(flagParameter, one, two);
+            var oneOrTwoEqualsTwo = Expression.Equal(oneOrTwo, two);
+            var testLambda = Expression.Lambda<Func<bool, bool>>(oneOrTwoEqualsTwo, flagParameter);
+
+            var translated = ToReadableString(testLambda);
+
+            translated.ShouldBe("flag => (flag ? Test.One : Test.Two) == Test.Two");
+        }
     }
 
     #region Helpers
@@ -495,5 +511,7 @@ public bool MultipleParameterMethod(string stringValue, int intValue)
         }
     }
 
+    internal enum Test { One, Two };
+
     #endregion
 }

ReadableExpressions/Translators/BinaryExpressionTranslator.cs

@@ -90,7 +90,7 @@ private static string TranslateOperand(Expression expression, TranslationContext
 
             var translation = context.Translate(expression);
 
-            return expression.IsAssignment()
+            return (expression.NodeType == ExpressionType.Conditional) || expression.IsAssignment()
                 ? translation.WithSurroundingParentheses()
                 : translation;
         }