Skip to content

Commit f0c8ce5

Browse files
authored
Chore/cleanup - remove samle apps and references (#152)
* chore: remove samples and references to them Signed-off-by: Laszlo Puskas <lpuskas@cisco.com> * chore: remove wfsm and references Signed-off-by: Laszlo Puskas <lpuskas@cisco.com> --------- Signed-off-by: Laszlo Puskas <lpuskas@cisco.com>
1 parent 5071955 commit f0c8ce5

File tree

103 files changed

+3
-31748
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

103 files changed

+3
-31748
lines changed

.github/workflows/test-integrations.yaml

Lines changed: 0 additions & 61 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,6 @@ on:
4949
required: false
5050
default: false
5151
type: boolean
52-
run_wfsm_test:
53-
description: "Run WFSM tests"
54-
required: false
55-
default: false
56-
type: boolean
5752

5853
schedule:
5954
- cron: "0 4 * * *"
@@ -207,62 +202,6 @@ jobs:
207202
run: task integrations:apps:run-marketing-campaign
208203
shell: bash
209204

210-
run-tests-wfsm:
211-
if: ${{ inputs.run_wfsm_test }}
212-
needs: [set-kind-version]
213-
runs-on: ubuntu-latest
214-
215-
permissions:
216-
contents: "read"
217-
id-token: "write"
218-
packages: "read"
219-
attestations: "read"
220-
221-
steps:
222-
- name: Checkout code
223-
uses: actions/checkout@v4
224-
with:
225-
fetch-depth: 0
226-
227-
- name: Login to GitHub Container Registry
228-
uses: docker/login-action@v3
229-
with:
230-
registry: ghcr.io
231-
username: ${{ github.actor }}
232-
password: ${{ secrets.GITHUB_TOKEN }}
233-
234-
- name: Setup Environment
235-
uses: ./.github/actions/setup-env
236-
with:
237-
python: true
238-
go: false
239-
240-
- name: Setup K8S Tools
241-
uses: ./.github/actions/setup-k8s
242-
with:
243-
kind-version: ${{ needs.set-kind-version.outputs.kind-version }}
244-
245-
- name: Deploy Directory
246-
uses: ./.github/actions/deploy-components
247-
with:
248-
deploy-directory: "true"
249-
directory-image-tag: "v0.2.3"
250-
directory-chart-tag: "v0.2.3"
251-
252-
- name: Run Workflow Server Manger Test
253-
env:
254-
AZURE_OPENAI_ENDPOINT: ${{ vars.AZURE_OPENAI_ENDPOINT }}
255-
AZURE_OPENAI_API_VERSION: ${{ vars.AZURE_OPENAI_API_VERSION }}
256-
AZURE_OPENAI_API_KEY: ${{ secrets.AZURE_OPENAI_API_KEY }}
257-
TEST_ENV_VAR: "anything"
258-
DIRCTL_BIN_VERSION: "v0.2.3"
259-
260-
run: |
261-
task integrations:directory:download:dirctl-bin
262-
task integrations:wfsm:wfsm:test:e2e
263-
264-
shell: bash
265-
266205
combine-all-artifacts:
267206
# Ensure this job runs only after all jobs that produce artifacts have completed
268207
needs:

.github/workflows/test-samples.yaml

Lines changed: 0 additions & 76 deletions
This file was deleted.

.gitignore

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,6 @@ integrations/**/charts/*
125125
# Kubeconfig
126126
integrations/kubeconfig.yaml
127127

128-
samples/**/report.md
129-
samples/evaluation/.deepeval*
130-
131128
# Binaries for testing
132129
integrations/**/.bin
133130

README.md

Lines changed: 3 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,8 @@
88
- [Running tests](#running-tests)
99
- [Running tests using GitHub actions](#running-tests-using-github-actions)
1010
- [How to extend tests with your own test](#how-to-extend-tests-with-your-own-test)
11-
- [Samples](#samples)
12-
- [Running tests](#running-tests-1)
13-
- [Updating the agntcy/dir testdata](#updating-the-agntcydir-testdata)
14-
- [Copyright Notice](#copyright-notice)
11+
- [Updating the agntcy/dir testdata](#updating-the-agntcydir-testdata)
12+
- [Copyright Notice](#copyright-notice)
1513

1614
## Architecture
1715

@@ -51,25 +49,7 @@ csit
5149
│   │   └── kind
5250
│   ├── Taskfile.yml # Tasks for integration tests
5351
│   └── testutils # Go test utils
54-
├── samples # Sample applications for testing
55-
│   ├── agents
56-
│   │   ├── docker-env-cli-stdout
57-
│   │   └── utils
58-
│   ├── autogen
59-
│   │   └── semantic-router
60-
│   ├── crewai
61-
│   │   └── simple_crew
62-
│   ├── evaluation
63-
│   │   ├── model
64-
│   │   └── tests
65-
│   ├── langgraph
66-
│   │   └── research
67-
│   ├── llama-deploy
68-
│   │   └── llama-sum
69-
│   ├── llama-index
70-
│   │   └── research
71-
│   └── Taskfile.yml # Tasks for Samples
72-
└── Taskfile.yml # Repository level task definintions
52+
└── Taskfile.yml # Repository level task definitions
7353
```
7454

7555
In the Taskfiles, all required tasks and steps are defined in a structured manner. Each CSIT component contains its necessary tasks within dedicated Taskfiles, with higher-level Taskfiles incorporating lower-level ones to efficiently leverage their defined tasks.
@@ -94,7 +74,6 @@ task: Available tasks for this project:
9474
* integrations:directory:test-env:deploy: Deploy Agntcy directory test env
9575
* integrations:directory:test-env:network:cleanup: Remove Directory network peers
9676
* integrations:directory:test-env:network:deploy: Deploy Directory network peers
97-
* integrations:directory:test:compile:samples: Agntcy compiler test in samples
9877
* integrations:directory:test:compiler: Agntcy compiler test
9978
* integrations:directory:test:delete: Directory agent delete test
10079
* integrations:directory:test:list: Directory agent list test
@@ -122,18 +101,6 @@ task: Available tasks for this project:
122101
* integrations:kind:create: Create kind cluster
123102
* integrations:kind:destroy: Destroy kind cluster
124103
* integrations:version: Get version
125-
* samples:agents:run:test: Run test
126-
* samples:autogen:kind: Run app in kind
127-
* samples:autogen:lint: Run lint with black
128-
* samples:autogen:lint-fix: Run lint and autofix with black
129-
* samples:autogen:run:test: Run tests
130-
* samples:crewai:run:crew: Run crew
131-
* samples:crewai:run:test: Run crew
132-
* samples:evaluation:run:crew: Run application main
133-
* samples:langgraph:run:test: Run tests
134-
* samples:llama-deploy:run:app: Run application main
135-
* samples:llama-deploy:run:test: Run tests
136-
* samples:llama-index:run:test: Run tests
137104
```
138105
139106
# Integration tests
@@ -300,64 +267,6 @@ git push origin add-new-test
300267
Go to the original repository on GitHub and submit a pull request from your branch.
301268
Provide a detailed description of what your test covers and any additional context needed for reviewers.
302269
303-
# Samples
304-
305-
The directory sturcture of the samples applications:
306-
307-
```
308-
samples
309-
├── crewai
310-
│   └── simple_crew # Agentic application example
311-
│   ├── agent.base.json # Required agent base model
312-
│   ├── build.config.yml # Required build configuration file
313-
│   ├── model.json # Required model file
314-
│   └── Taskfile.yml # Tasks for samples tests
315-
├── langgraph
316-
│   └── research # Agentic application example
317-
│   ├── agent.base.json # Required agent base model
318-
│   ├── build.config.yml # Required build configuration file
319-
│   ├── model.json # Required model file
320-
│   ├── Taskfile.yml # Tasks for samples tests
321-
│   └── tests
322-
├── llama-index
323-
│   └── research # Agentic application example
324-
│   ├── agent.base.json # Required agent base model
325-
│   ├── build.config.yml # Required build configuration file
326-
│   ├── model.json # Required model file
327-
│   ├── Taskfile.yml # Tasks for samples tests
328-
│   └── tests
329-
├── ....
330-
├── ....
331-
│  
332-
└── Taskfile.yml
333-
```
334-
335-
The samples directory in the CSIT repository serves two primary purposes related to the testing of agentic applications:
336-
337-
338-
1. Compilation and Execution Verification: The agentic applications stored within the samples directory are subjected to sample tests. These tests are designed to run whenever changes are made to the agentic apps to ensure they compile correctly and are able to execute as expected.
339-
2. Base for Agent Directory Integration Test:
340-
The agentic applications in the samples directory also serve as the foundation for the agent model build and push test. This specific test checks for the presence of two required files: model.json and build.config.yaml. If these files are present within an agentic application, the integration agent model build and push testa are triggered. This test is crucial for validating the construction and verification of the agent model, ensuring that all necessary components are correctly configured and operational.
341-
342-
## Running tests
343-
344-
We can launch tests using taskfile locally or in GitHub actions.
345-
Running locally we need some tools to build the sample applications and run the tests.
346-
It requires the followings on local machine:
347-
- [Taskfile](https://taskfile.dev/installation/)
348-
- [Python 3.12.X](https://www.python.org/downloads/)
349-
- [Poetry](https://python-poetry.org/docs/#installation)
350-
- [Docker](https://docs.docker.com/get-started/get-docker/)
351-
- [Kind](https://kind.sigs.k8s.io/docs/user/quick-start#installation)
352-
- [Kubectl](https://kubernetes.io/docs/tasks/tools/#kubectl)
353-
354-
```bash
355-
task samples:<app-namel>:run:test
356-
or
357-
cd samples/[app-name]
358-
task run:test
359-
```
360-
361270
## Updating the agntcy/dir testdata
362271
363272
If we want to update the `integrations/agntcy-dir/examples/dir/e2e/testdata` directory we will need to add `agntcy/dir` as a remote and create a patch for it by diffing with the `agntcy/dir` repo

Taskfile.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,6 @@ includes:
1717
SLIM_IMAGE_TAG: '{{ .SLIM_IMAGE_TAG }}'
1818
SLIM_CHART_TAG: '{{ .SLIM_CHART_TAG }}'
1919

20-
samples:
21-
taskfile: ./samples/Taskfile.yml
22-
dir: ./samples
23-
excludes: [default]
24-
2520
benchmarks:
2621
taskfile: ./benchmarks/Taskfile.yml
2722
dir: ./benchmarks

integrations/Taskfile.yml

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -34,13 +34,6 @@ includes:
3434
vars:
3535
WFSM_BIN_VERSION: '{{ .WFSM_BIN_VERSION }}'
3636

37-
wfsm:
38-
taskfile: ./agntcy-wfsm/Taskfile.yml
39-
dir: ./agntcy-wfsm
40-
excludes: [ default ]
41-
vars:
42-
WFSM_BIN_VERSION: '{{ .WFSM_BIN_VERSION }}'
43-
4437
vars:
4538
KIND_CLUSTER_NAME: '{{ .KIND_CLUSTER_NAME | default "agntcy-test" }}'
4639

integrations/agntcy-dir/Taskfile.yml

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -260,12 +260,6 @@ tasks:
260260
- docker pull {{.IMAGE_REPO}}/dir-ctl:{{.DIRECTORY_IMAGE_TAG}}
261261
- REMOVE_CONTAINERS={{.REMOVE_CONTAINERS}} RUNNER_TYPE={{.RUNNER_TYPE}} PATH=$PATH:{{.DIRCTL_BIN_PATH}} IMAGE_REPO={{.IMAGE_REPO}} DIRECTORY_IMAGE_TAG={{.DIRECTORY_IMAGE_TAG}} go test ./tests -v -failfast -test.v -test.paniconexit0 -ginkgo.timeout 10m -timeout 10m -ginkgo.v -ginkgo.focus "agent compilation"
262262

263-
test:compile:samples:
264-
desc: Agntcy compiler test in samples
265-
cmds:
266-
- docker pull {{.IMAGE_REPO}}/dir-ctl:{{.DIRECTORY_IMAGE_TAG}}
267-
- REMOVE_CONTAINERS={{.REMOVE_CONTAINERS}} RUNNER_TYPE={{.RUNNER_TYPE}} PATH=$PATH:{{.DIRCTL_BIN_PATH}} IMAGE_REPO={{.IMAGE_REPO}} DIRECTORY_IMAGE_TAG={{.DIRECTORY_IMAGE_TAG}} go test ./tests -v -failfast -test.v -test.paniconexit0 -ginkgo.timeout 10m -timeout 10m -ginkgo.v -ginkgo.focus "Samples build test"
268-
269263
test:push:
270264
desc: Directory agent push test
271265
cmds:

0 commit comments

Comments
 (0)