Skip to content

Commit 8bee533

Browse files
committed
ci: remove incorrect support for inputs.name
The `test.yaml` workflow was using `inputs.name`, but it only worked because the `name` input was not defined in the `starship-action`. When `inputs.name` support was implemented in PR hyperweb-io#42, it broke the `test.yaml` workflow because the `starship stop --name` setting overrode the `config.yml` `name:` value. This installed the Helm release with a different name than what was being stopped. Without stopping the correct Helm release, `starship stop` would hang indefinitely. Now it doesn't.
1 parent ae52154 commit 8bee533

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

.github/workflows/test.yaml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,6 @@ jobs:
5555
- uses: ./
5656
id: starship
5757
with:
58-
name: test-with-values
5958
config: config.yaml
6059

6160
- name: Check kubectl pods
@@ -134,7 +133,6 @@ jobs:
134133
- uses: ./
135134
id: starship
136135
with:
137-
name: test-kubeconfig
138136
kubeconfig: ${{ steps.kubeconfig.outputs.content }}
139137
config: config.yaml
140138

@@ -175,7 +173,6 @@ jobs:
175173
- uses: ./
176174
id: starship
177175
with:
178-
name: test-no-portforward
179176
config: config.yaml
180177

181178
- name: Check kubectl pods

action.yaml

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -24,10 +24,6 @@ inputs:
2424
description: "Helm repo to fetch the chart from (default: https://hyperweb-io.github.io/starship)"
2525
required: false
2626
default: "https://hyperweb-io.github.io/starship"
27-
name:
28-
description: "Helm chart release name for installing helm chart"
29-
required: false
30-
default: "starship"
3127
namespace:
3228
description: "Kubernetes namespace to deploy helm charts on (default: ci-{github.repository}-{github.workflow}-{github.ref} )"
3329
required: false
@@ -41,9 +37,6 @@ outputs:
4137
namespace:
4238
description: "Kubernetes namespace to which helm charts were deployed"
4339
value: ${{ steps.set-namespace.outputs.namespace }}
44-
name:
45-
description: "Helm chart release name for installing helm chart"
46-
value: ${{ inputs.name }}
4740

4841
runs:
4942
using: composite
@@ -146,7 +139,6 @@ runs:
146139
sleep 5
147140
starship start \
148141
--config ${{ inputs.config }} \
149-
--name ${{ inputs.name }} \
150142
--namespace ${{ steps.set-namespace.outputs.namespace }} \
151143
--repoUrl ${{ inputs.repo }} \
152144
--chart ${{ inputs.chart }} \
@@ -179,7 +171,6 @@ runs:
179171
kubectl get pods --namespace ${{ steps.set-namespace.outputs.namespace }}
180172
starship start \
181173
--config ${{ inputs.config }} \
182-
--name ${{ inputs.name }} \
183174
--namespace ${{ steps.set-namespace.outputs.namespace }} \
184175
--repoUrl ${{ inputs.repo }} \
185176
--chart ${{ inputs.chart }} \
@@ -195,7 +186,6 @@ runs:
195186
kubectl get pods --namespace ${{ steps.set-namespace.outputs.namespace }}
196187
starship start \
197188
--config ${{ inputs.config }} \
198-
--name ${{ inputs.name }} \
199189
--namespace ${{ steps.set-namespace.outputs.namespace }} \
200190
--repoUrl ${{ inputs.repo }} \
201191
--chart ${{ inputs.chart }} \

0 commit comments

Comments
 (0)