Skip to content

Commit c0b6e68

Browse files
authored
Remove core_extensions.js (x-tools#530)
Most of it seems unused. * descore: unused * score: used once; I'd say just use .replace * escape: unused * unique: unused * capitalize: used twice one right after the other. IMO we can just use a local function for this. I have replaced the few uses and removed that file. (Hacking at a global object's prototype is never a good idea.) Bug: T394581
1 parent eeccee8 commit c0b6e68

File tree

9 files changed

+8
-48
lines changed

9 files changed

+8
-48
lines changed

assets/js/categoryedits.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ function setupCategoryInput(api, ns)
107107
results = query.prefixsearch.map(function (elem) {
108108
var title = elem.title.replace(new RegExp('^' + nsName + ':'), '');
109109
return {
110-
id: title.score(),
110+
id: title.replace(/ /g, '_'),
111111
text: title
112112
};
113113
});

assets/js/common/contributions-lists.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -143,11 +143,12 @@ xtools.application.setupContributionsNavListeners = function (endpointFunc, apiT
143143
$('#contributions_limit').on('change', function (e) {
144144
var limit = parseInt(e.target.value, 10);
145145
$('.contributions-container').data('limit', limit);
146+
let capitalize = (str) => str[0].toUpperCase() + str.slice(1);
146147
$('.contributions--prev-text').text(
147-
$.i18n('pager-newer-n', limit).capitalize()
148+
capitalize($.i18n('pager-newer-n', limit))
148149
);
149150
$('.contributions--next-text').text(
150-
$.i18n('pager-older-n', limit).capitalize()
151+
capitalize($.i18n('pager-older-n', limit))
151152
);
152153
});
153154
};

assets/js/common/core_extensions.js

Lines changed: 0 additions & 40 deletions
This file was deleted.

public/build/app.27cd0c82.js

Lines changed: 0 additions & 2 deletions
This file was deleted.

public/build/app.65582b0e.js

Lines changed: 2 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

public/build/entrypoints.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
"js": [
55
"/build/runtime.c217f8c4.js",
66
"/build/95.7a87ed1a.js",
7-
"/build/app.27cd0c82.js"
7+
"/build/app.65582b0e.js"
88
],
99
"css": [
1010
"/build/app.da10c09b.css"

public/build/manifest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"build/app.css": "/build/app.da10c09b.css",
3-
"build/app.js": "/build/app.27cd0c82.js",
3+
"build/app.js": "/build/app.65582b0e.js",
44
"build/runtime.js": "/build/runtime.c217f8c4.js",
55
"build/95.7a87ed1a.js": "/build/95.7a87ed1a.js",
66
"build/images/VPS-badge.svg": "/build/images/VPS-badge.svg",

webpack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ Encore
3636
'./assets/vendor/jquery.i18n/jquery.i18n.dist.js',
3737
'./assets/vendor/Chart.min.js',
3838
'./assets/vendor/bootstrap-typeahead.js',
39-
'./assets/js/common/core_extensions.js',
4039
'./assets/js/common/application.js',
4140
'./assets/js/common/contributions-lists.js',
4241
'./assets/js/adminstats.js',

0 commit comments

Comments
 (0)