fix(api): skip email if recipients are empty

Author: steveoh

functions/database/submissions/onCancelSubmission.js

@@ -10,6 +10,12 @@ export const cancelSubmission = async (before) => {
   // only email ugrc with empty county
   const to = await getContactsToNotify(db, null);
 
+  if (!to || to.length === 0) {
+    logger.error('no contacts to notify', { structuredData: true });
+
+    return;
+  }
+
   const template = {
     method: 'post',
     url: '/v3/mail/send',

functions/emailHelper.test.js

@@ -11,6 +11,7 @@ const docMock = vi.fn(() => {
             beaver: [{ name: 'beaver', email: 'beaver-email' }],
           };
         }),
+        exists: true,
       };
     }),
   };

functions/emailHelpers.js

@@ -31,6 +31,7 @@ export const notify = (key, template) => {
 export const getContactsToNotify = async (db, county) => {
   const documentReference = db.collection('contacts').doc('admin');
   const documentSnapshot = await documentReference.get();
+
   if (!documentSnapshot.exists) {
     logger.error('contacts document does not exist', {
       structuredData: true,

functions/storage/onCreateNotify.js

@@ -50,6 +50,12 @@ export const createNotify = async (
   // TODO add document.county to add the county contacts #199
   const to = await getContactsToNotify(db, null);
 
+  if (!to || to.length === 0) {
+    logger.error('no contacts to notify', { structuredData: true });
+
+    return;
+  }
+
   const template = {
     method: 'post',
     url: '/v3/mail/send',