Fix test-binary-size-linux -Wsign-compare failure with c10::irange (pytorch#13481)

swolchok · agrima1304 · commit e1e3933297d5 · 2025-08-26T14:48:53.000+01:00
pytorch#13199 broke it on Friday afternoon.
diff --git a/kernels/portable/cpu/op_stack.cpp b/kernels/portable/cpu/op_stack.cpp
@@ -8,6 +8,7 @@
 
 #include <cstring>
 
+#include <c10/util/irange.h>
 #include <executorch/kernels/portable/cpu/util/copy_ops_util.h>
 #include <executorch/runtime/kernel/kernel_includes.h>
 
@@ -126,7 +127,7 @@ stack_out_shape(executorch::aten::ArrayRef<Tensor> tensors, int64_t dim) {
     if (tensors[i].dim() != tensors[0].dim()) {
       return std::make_tuple(Error::InvalidArgument, out_sizes, out_dim);
     }
-    for (size_t d = 0; d < tensors[0].dim(); ++d) {
+    for (const auto d : c10::irange(tensors[0].dim())) {
       if (tensors[i].size(d) != tensors[0].size(d)) {
         return std::make_tuple(Error::InvalidArgument, out_sizes, out_dim);
       }

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`
`9`	`9`	`#include <cstring>`
`10`	`10`
	`11`	`+#include <c10/util/irange.h>`
`11`	`12`	`#include <executorch/kernels/portable/cpu/util/copy_ops_util.h>`
`12`	`13`	`#include <executorch/runtime/kernel/kernel_includes.h>`
`13`	`14`
`@@ -126,7 +127,7 @@ stack_out_shape(executorch::aten::ArrayRef<Tensor> tensors, int64_t dim) {`
`126`	`127`	`if (tensors[i].dim() != tensors[0].dim()) {`
`127`	`128`	`return std::make_tuple(Error::InvalidArgument, out_sizes, out_dim);`
`128`	`129`	`}`
`129`		`- for (size_t d = 0; d < tensors[0].dim(); ++d) {`
	`130`	`+ for (const auto d : c10::irange(tensors[0].dim())) {`
`130`	`131`	`if (tensors[i].size(d) != tensors[0].size(d)) {`
`131`	`132`	`return std::make_tuple(Error::InvalidArgument, out_sizes, out_dim);`
`132`	`133`	`}`