feat: make handling units respect config, add defaults (#309)

Author: agritheory

.pre-commit-config.yaml

@@ -55,7 +55,7 @@ repos:
           - tomli
 
   - repo: https://github.com/agritheory/test_utils
-    rev: v1.7.1
+    rev: v1.12.0
     hooks:
       - id: update_pre_commit_config
       - id: validate_copyright

beam/beam/boot.py

@@ -1,9 +1,28 @@
 # Copyright (c) 2025, AgriTheory and contributors
 # For license information, please see license.txt
 
+import frappe
 
 from beam.beam.scan.config import get_scan_doctypes
 
 
 def boot_session(bootinfo):
 	bootinfo.beam = get_scan_doctypes()
+	bootinfo.beam["settings"] = get_beam_settings()
+	bootinfo.beam["default_hu_print_format"] = frappe.get_meta("Handling Unit").get(
+		"default_print_format"
+	)
+
+
+def get_beam_settings():
+	"""Get BEAM Settings for all companies, keyed by company name."""
+	settings = {}
+	beam_settings = frappe.get_all(
+		"BEAM Settings",
+		fields=["company", "enable_handling_units"],
+	)
+	for setting in beam_settings:
+		settings[setting.company] = {
+			"enable_handling_units": setting.enable_handling_units,
+		}
+	return settings

beam/public/js/print/print.js

@@ -40,47 +40,49 @@ function custom_print_button(frm) {
 	if (frm.doc.docstatus != 1) {
 		return
 	}
-	frappe.db.get_value('BEAM Settings', { company: frm.doc.company }, 'enable_handling_units', r => {
-		if (r && r.enable_handling_units) {
-			frm.add_custom_button(__('<span class="fa fa-print"></span> Print Handling Unit'), () => {
-				let d = new frappe.ui.Dialog({
-					title: __('Select Printer Setting'),
-					fields: [
-						{
-							label: __('Printer Setting'),
-							fieldname: 'printer_setting',
-							fieldtype: 'Link',
-							options: 'Network Printer Settings',
-						},
-						{
-							label: __('Printer Format'),
-							fieldname: 'print_format',
-							fieldtype: 'Link',
-							options: 'Print Format',
-							get_query: function () {
-								return {
-									filters: { doc_type: 'Handling Unit' },
-								}
-							},
-						},
-					],
-					primary_action_label: 'Select',
-					primary_action(selection) {
-						d.hide()
-						frappe.call({
-							method: 'beam.beam.printing.print_handling_units',
-							args: {
-								doctype: frm.doc.doctype,
-								name: frm.doc.name,
-								printer_setting: selection.printer_setting,
-								print_format: selection.print_format,
-								doc: frm.doc,
-							},
-						})
+	const beam_settings = frappe.boot.beam?.settings?.[frm.doc.company]
+	if (!beam_settings?.enable_handling_units) {
+		return
+	}
+	frm.add_custom_button(__('<span class="fa fa-print"></span> Print Handling Unit'), () => {
+		let d = new frappe.ui.Dialog({
+			title: __('Select Printer Setting'),
+			fields: [
+				{
+					label: __('Printer Setting'),
+					fieldname: 'printer_setting',
+					fieldtype: 'Link',
+					options: 'Network Printer Settings',
+					default: frappe.defaults.get_user_default('Network Printer Settings'),
+				},
+				{
+					label: __('Print Format'),
+					fieldname: 'print_format',
+					fieldtype: 'Link',
+					options: 'Print Format',
+					default: frappe.boot.beam?.default_hu_print_format,
+					get_query: function () {
+						return {
+							filters: { doc_type: 'Handling Unit' },
+						}
+					},
+				},
+			],
+			primary_action_label: 'Select',
+			primary_action(selection) {
+				d.hide()
+				frappe.call({
+					method: 'beam.beam.printing.print_handling_units',
+					args: {
+						doctype: frm.doc.doctype,
+						name: frm.doc.name,
+						printer_setting: selection.printer_setting,
+						print_format: selection.print_format,
+						doc: frm.doc,
 					},
 				})
-				d.show()
-			})
-		}
+			},
+		})
+		d.show()
 	})
 }