integrate feedback

Author: danplischke

CHANGES.rst

@@ -2,6 +2,7 @@ Version history
 ===============
 
 **UNRELEASED**
+
 - Handle SQLAlchemy type with unimplemented python_type as typing.Any (PR by @danplischke)
 - Fix SQLModel metadata reference (PR by @danplischke)
 

src/sqlacodegen/generators.py

@@ -1246,14 +1246,15 @@ def render_python_type(column_type: TypeEngine[Any]) -> str:
                 try:
                     python_type = column_type.python_type
                 except NotImplementedError:
-                    self.add_literal_import("typing", "Any")
+                    self.add_import(Any)
                     python_type = Any
 
             python_type_name = (
                 python_type.__name__
                 if hasattr(python_type, "__name__")
                 else python_type._name
             )
+
             python_type_module = python_type.__module__
             if python_type_module == "builtins":
                 return python_type_name

tests/test_generator_sqlmodel.py

@@ -233,3 +233,33 @@ class SimpleTsvector(SQLModel, table=True):
             search: Optional[typing.Any] = Field(default=None, sa_column=Column('search', TSVECTOR))
         """,
     )
+
+
+def test_metadata_ref(generator: CodeGenerator) -> None:
+    from sqlmodel import SQLModel
+
+    Table(
+        "metadata_ref_test_table",
+        generator.metadata,
+        Column("id", INTEGER, primary_key=True),
+    )
+
+    code = generator.generate()
+    validate_code(
+        code,
+        """\
+            from sqlalchemy import Column, Integer
+            from sqlmodel import Field, SQLModel
+
+            class MetadataRefTestTable(SQLModel, table=True):
+                __tablename__ = 'metadata_ref_test_table'
+
+                id: int = Field(sa_column=Column('id', Integer, primary_key=True))
+        """,
+    )
+
+    SQLModel.metadata.clear()  # clear the metadata to avoid with the tables defined in this test
+    exec(code, globals())
+
+    assert len(SQLModel.metadata.tables) == 1
+    assert "metadata_ref_test_table" in SQLModel.metadata.tables