Merge pull request #376 from momoAmch/bug/add_check_forUndefiend_objectProps

check undefiend objects props

Author: RogerHardiman

lib/media.js

@@ -301,7 +301,7 @@ module.exports = function(Cam) {
 			}
 		} else if (typeof options == "string") { // For backward compatibility
 			options = { configurationToken: options };
-		} else if (!(options && (options.configurationToken || options.profileToken))) {
+		} else if (!(options && (options.configurationToken !== undefined || options.profileToken !== undefined))) {
 			return callback(new Error("'options' must have one or both 'configurationToken' or 'profileToken'"));
 		}
 		const service = this.media2Support ? 'media2' : 'media';
@@ -394,7 +394,7 @@ module.exports = function(Cam) {
 	 * @param {Cam~VideoEncoderConfigurationCallback} callback
 	 */
 	Cam.prototype.setVideoEncoderConfiguration = function(options, callback) {
-		if (!options.token && !(options.$ && options.$.token)) {
+		if (options.token === undefined && !(options.$ && options.$.token !== undefined)) {
 			return callback(new Error('No video encoder configuration token is present!'));
 		}
 		const service = this.media2Support ? 'media2' : 'media';
@@ -418,9 +418,9 @@ module.exports = function(Cam) {
 				( options.quality ? '<Quality xmlns="http://www.onvif.org/ver10/schema">' + options.quality + '</Quality>' : '' ) +
 				( options.rateControl ?
 					`<RateControl ConstantBitRate="${ConstantBitRate}"  xmlns="http://www.onvif.org/ver10/schema"> ` +
-					( options.rateControl.frameRateLimit ? '<FrameRateLimit>' + options.rateControl.frameRateLimit + '</FrameRateLimit>' : '' ) +
-					( options.rateControl.encodingInterval ? '<EncodingInterval>' + options.rateControl.encodingInterval + '</EncodingInterval>' : '' ) +
-					( options.rateControl.bitrateLimit ? '<BitrateLimit>' + options.rateControl.bitrateLimit + '</BitrateLimit>' : '' ) +
+					( options.rateControl.frameRateLimit !== undefined ? '<FrameRateLimit>' + options.rateControl.frameRateLimit + '</FrameRateLimit>' : '' ) +
+					( options.rateControl.encodingInterval !== undefined ? '<EncodingInterval>' + options.rateControl.encodingInterval + '</EncodingInterval>' : '' ) +
+					( options.rateControl.bitrateLimit !== undefined ? '<BitrateLimit>' + options.rateControl.bitrateLimit + '</BitrateLimit>' : '' ) +
 				'</RateControl>' : '' ) +
 				( options.MPEG4 ?
 					'<MPEG4 xmlns="http://www.onvif.org/ver10/schema">' +
@@ -589,7 +589,7 @@ module.exports = function(Cam) {
 	 * @param {Cam~AudioEncoderConfigurationCallback} callback
 	 */
 	Cam.prototype.setAudioEncoderConfiguration = function(options, callback) {
-		if (!options.token && !(options.$ && options.$.token)) {
+		if (options.token === undefined && !(options.$ && options.$.token !== undefined)) {
 			return callback(new Error('No audio encoder configuration token is present!'));
 		}
 		this._request({